Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Extract zlib-related logic into a single module (#7223) #7250

Conversation

Dreamsorcerer
Copy link
Member

Backport #7223

Addresses issue #7192 Refactors the logic to have the zlib-related stuff concentrated into a single module

No

#7192

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
  • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following: * .feature: Signifying a new feature. * .bugfix: Signifying a bug fix. * .doc: Signifying a documentation improvement. * .removal: Signifying a deprecation or removal of public API.
  • .misc: A ticket has been closed, but it is not of interest to users.
  • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sam Bull aa6bs0@sambull.org
(cherry picked from commit 3ff81dc)

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

<!-- Thank you for your contribution! -->

Addresses issue #7192
Refactors the logic to have the zlib-related stuff concentrated into a
single module

No

#7192

- [x] I think the code is well written
- [x] Unit tests for the changes exist
- [ ] Documentation reflects the changes
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`
  * The format is &lt;Name&gt; &lt;Surname&gt;.
  * Please keep alphabetical order, the file is sorted by names.
- [ ] Add a new news fragment into the `CHANGES` folder
  * name it `<issue_id>.<type>` for example (588.bugfix)
* if you don't have an `issue_id` change it to the pr id after creating
the pr
  * ensure type is one of the following:
    * `.feature`: Signifying a new feature.
    * `.bugfix`: Signifying a bug fix.
    * `.doc`: Signifying a documentation improvement.
    * `.removal`: Signifying a deprecation or removal of public API.
* `.misc`: A ticket has been closed, but it is not of interest to users.
* Make sure to use full sentences with correct case and punctuation, for
example: "Fix issue with non-ascii contents in doctest text files."

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
(cherry picked from commit 3ff81dc)
@Dreamsorcerer Dreamsorcerer added the bot:chronographer:skip This PR does not need to include a change note label Apr 8, 2023
@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Merging #7250 (728b5c7) into 3.9 (43e568b) will decrease coverage by 0.03%.
The diff coverage is 88.46%.

@@            Coverage Diff             @@
##              3.9    #7250      +/-   ##
==========================================
- Coverage   97.34%   97.32%   -0.03%     
==========================================
  Files         107      108       +1     
  Lines       31490    31587      +97     
  Branches     3977     4012      +35     
==========================================
+ Hits        30654    30741      +87     
- Misses        634      640       +6     
- Partials      202      206       +4     
Flag Coverage Δ
CI-GHA 97.22% <88.46%> (-0.03%) ⬇️
OS-Linux 96.88% <88.46%> (-0.03%) ⬇️
OS-Windows 94.48% <88.46%> (-0.02%) ⬇️
OS-macOS 96.46% <88.46%> (-0.03%) ⬇️
Py-3.10.10 96.95% <88.46%> (-0.03%) ⬇️
Py-3.11.0 96.39% <88.46%> (-0.03%) ⬇️
Py-3.7.16 96.69% <88.46%> (-0.03%) ⬇️
Py-3.7.9 94.33% <88.46%> (-0.02%) ⬇️
Py-3.8.10 94.26% <88.46%> (-0.02%) ⬇️
Py-3.8.16 96.60% <88.46%> (-0.03%) ⬇️
Py-3.9.13 94.27% <88.46%> (-0.02%) ⬇️
Py-3.9.16 96.63% <88.46%> (-0.03%) ⬇️
Py-pypy7.3.11 94.03% <85.57%> (-0.05%) ⬇️
VM-macos 96.46% <88.46%> (-0.03%) ⬇️
VM-ubuntu 96.88% <88.46%> (-0.03%) ⬇️
VM-windows 94.48% <88.46%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/client_reqrep.py 97.84% <ø> (+0.01%) ⬆️
aiohttp/web_response.py 98.11% <75.00%> (-0.45%) ⬇️
aiohttp/compression_utils.py 84.61% <84.61%> (ø)
aiohttp/http_parser.py 98.29% <100.00%> (+0.78%) ⬆️
aiohttp/http_websocket.py 99.22% <100.00%> (+<0.01%) ⬆️
aiohttp/http_writer.py 99.15% <100.00%> (ø)
aiohttp/multipart.py 96.80% <100.00%> (-0.02%) ⬇️
tests/test_http_parser.py 99.08% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Dreamsorcerer Dreamsorcerer enabled auto-merge (squash) April 8, 2023 20:08
@Dreamsorcerer Dreamsorcerer merged commit 586778f into 3.9 Apr 8, 2023
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.9/3ff81dc9c9ce20efd3bf54cf52adaf438c483a92/pr-7223 branch April 8, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants