-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aiohttp.web command-line interface to serve apps #740
Conversation
@@ -0,0 +1,43 @@ | |||
from .web import run_app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the file content to the end of web.py
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay...I wasn't sure about the layout.
I was trying to emulate some resemblance to a package level __main__.py
.
Speaking of which could web
be turned into a proper sub-package, or would that break backwards compatibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aiohttp will keep flat structure without sub-packages.
The tests are needed: I'm fine with mocking |
Looks good in general. |
@asvetlov Ping |
Add aiohttp.web command-line interface to serve apps
Perfect! |
Most of the stuff discussed in issue #733 is implemented, with the exception of an awaitable entry point function. It doesn't make much sense to have an awaitable function since that function is the one creating the event loop.