Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aiohttp.web command-line interface to serve apps #740

Merged
merged 7 commits into from
Jan 19, 2016

Conversation

jashandeep-sohi
Copy link
Contributor

Most of the stuff discussed in issue #733 is implemented, with the exception of an awaitable entry point function. It doesn't make much sense to have an awaitable function since that function is the one creating the event loop.

@@ -0,0 +1,43 @@
from .web import run_app
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the file content to the end of web.py.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay...I wasn't sure about the layout.
I was trying to emulate some resemblance to a package level __main__.py.
Speaking of which could web be turned into a proper sub-package, or would that break backwards compatibility?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aiohttp will keep flat structure without sub-packages.

@asvetlov
Copy link
Member

The tests are needed: I'm fine with mocking web.run_app but all other code should be tested.

@asvetlov
Copy link
Member

Looks good in general.

@jashandeep-sohi
Copy link
Contributor Author

@asvetlov Ping
Please review the tests.

asvetlov added a commit that referenced this pull request Jan 19, 2016
Add aiohttp.web command-line interface to serve apps
@asvetlov asvetlov merged commit 6f4ed33 into aio-libs:master Jan 19, 2016
@asvetlov
Copy link
Member

Perfect!

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants