Implement WebSocketResponse.get_extra_info method to avoid using private member #7658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
webknjaz
reviewed
Oct 6, 2023
Codecov Report
@@ Coverage Diff @@
## master #7658 +/- ##
=======================================
Coverage 97.36% 97.36%
=======================================
Files 106 106
Lines 31648 31665 +17
Branches 3620 3624 +4
=======================================
+ Hits 30813 30830 +17
Misses 632 632
Partials 203 203
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ttsia
force-pushed
the
7078-implement-WebSocketResponse.get_extra_info
branch
3 times, most recently
from
f203412
to
efa76ed
Compare
ttsia
changed the title
ttsia
force-pushed
the
7078-implement-WebSocketResponse.get_extra_info
branch
2 times, most recently
from
48fbda6
to
4b41505
Compare
ttsia
force-pushed
the
7078-implement-WebSocketResponse.get_extra_info
branch
from
4b41505
to
0da90df
Compare
ttsia
force-pushed
the
7078-implement-WebSocketResponse.get_extra_info
branch
from
0da90df
to
4ea8d2d
Compare
Backport to 3.9: 💚 backport PR created✅ Backport PR branch: Backported as #7695 🤖 @patchback |
5 tasks
Dreamsorcerer
pushed a commit
that referenced
this pull request
Oct 12, 2023
xiangxli
pushed a commit
to xiangxli/aiohttp
that referenced
this pull request
Dec 4, 2023
….get_extra_info method to avoid using private member (aio-libs#7695) **This is a backport of PR aio-libs#7658 as merged into master (39f8ff2).**
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This change introduces new method to access get_extra_info from a WebSocketResponse, like its possible in ClientWebSocketResponse to avoid accessing the private member like in
response._writer.transport.get_extra_info("the info")Related issue number
#7078
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.