Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CONNECT always being treated as having an empty body (#7772) #7774

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 31, 2023

(cherry picked from commit af2bb1e)

@bdraco bdraco requested a review from asvetlov as a code owner October 31, 2023 17:16
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 31, 2023
@Dreamsorcerer Dreamsorcerer enabled auto-merge (squash) October 31, 2023 17:38
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #7774 (b940aeb) into 3.9 (5e62fee) will increase coverage by 0.00%.
Report is 1 commits behind head on 3.9.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              3.9    #7774   +/-   ##
=======================================
  Coverage   97.31%   97.31%           
=======================================
  Files         107      107           
  Lines       32002    32005    +3     
  Branches     3735     3735           
=======================================
+ Hits        31142    31145    +3     
  Misses        654      654           
  Partials      206      206           
Flag Coverage Δ
CI-GHA 97.22% <100.00%> (+<0.01%) ⬆️
OS-Linux 96.91% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.43% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.56% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 94.35% <100.00%> (+<0.01%) ⬆️
Py-3.10.13 96.75% <100.00%> (+<0.01%) ⬆️
Py-3.11.6 96.44% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 94.32% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.68% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 94.32% <100.00%> (+<0.01%) ⬆️
Py-3.9.18 96.72% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.11 96.11% <100.00%> (+<0.01%) ⬆️
VM-macos 96.56% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 96.91% <100.00%> (+<0.01%) ⬆️
VM-windows 94.43% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
aiohttp/helpers.py 95.16% <100.00%> (ø)
tests/test_helpers.py 98.87% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Dreamsorcerer Dreamsorcerer merged commit 598334f into aio-libs:3.9 Oct 31, 2023
24 of 29 checks passed
xiangxli pushed a commit to xiangxli/aiohttp that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants