Add a test case for #7859 #7866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Comment on lines
+121
to
+130
| == b"\xc1)\xec\xd0\x81\x10\x00\x00\x00\x03!\xd7\xf7\x87\x98\xc7\xae\x10*\x0c" | ||
| b"\x180`\xc0\x80\x01\x03\x06\x0c\x180`\xc0\x80\x01\x03\x06\x0c\x18\xb8\x1d" | ||
| b"\x18\x00" | ||
| ) | ||
| for result in writer.transport.write.call_args_list[1:]: | ||
| assert ( | ||
| result[0][0] | ||
| == b"\xc1&\xec\xd0\x81\x0c\x00\x00\x00\xc0 \x7f\xeb{|\x85\x10\x06\x0c" | ||
| b"\x180`\xc0\x80\x01\x03\x06\x0c\x180`\xc0\x80\x01\x03\x06\x0c\x8c" | ||
| b"\x07\x02" |
There was a problem hiding this comment.
Rather than depending on the compressed bytes, which is rather hard to evaluate, can we test that reading/decompressing gives the expected output?
There was a problem hiding this comment.
I think bdraco has already got this covered actually: https://github.com/aio-libs/aiohttp/pull/7865/files#diff-c82db6bac3cc2b13785c62de3180bef31a0dc1046cdc7655ca7d873d6c220eb4R114
So, we can probably close this one.
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
|
Superseded by #7865. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Add a test for #7859
Are there changes in behavior for the user?
no
Related issue number
#7859
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.