Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to llhttp 9.2 #8146

Merged
merged 5 commits into from
Feb 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/8146.feature.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Upgraded *llhttp* to 9.2 -- by :user:`Dreamsorcerer`.
18 changes: 0 additions & 18 deletions tests/test_http_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -622,25 +622,9 @@ def test_headers_content_length_err_2(parser: Any) -> None:
}


@pytest.fixture
def xfail_c_parser_empty_header(request) -> None:
if not all(
(request.getfixturevalue(name) == b"") for name in ("pad1", "pad2", "hdr")
):
return
if isinstance(request.getfixturevalue("parser"), HttpRequestParserPy):
return
request.node.add_marker(
pytest.mark.xfail(
reason="Regression test for Py parser. May match C behaviour later.",
)
)


@pytest.mark.parametrize("hdr", [b"", b"foo"], ids=["name-empty", "with-name"])
@pytest.mark.parametrize("pad2", _pad.keys(), ids=["post-" + n for n in _pad.values()])
@pytest.mark.parametrize("pad1", _pad.keys(), ids=["pre-" + n for n in _pad.values()])
@pytest.mark.usefixtures("xfail_c_parser_empty_header")
def test_invalid_header_spacing(
parser: Any, pad1: bytes, pad2: bytes, hdr: bytes
) -> None:
Expand All @@ -654,8 +638,6 @@ def test_invalid_header_spacing(


def test_empty_header_name(parser: Any) -> None:
if not isinstance(parser, HttpRequestParserPy):
pytest.xfail("Regression test for Py parser. May match C behaviour later.")
text = b"GET /test HTTP/1.1\r\n" b":test\r\n\r\n"
with pytest.raises(http_exceptions.BadHttpMessage):
parser.feed_data(text)
Expand Down
Loading