Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python parser to mark responses without length as closing #8320

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Fix Python parser to mark responses without length as closing #8320

merged 4 commits into from
Apr 11, 2024

Conversation

Dreamsorcerer
Copy link
Member

No description provided.

@Dreamsorcerer Dreamsorcerer requested a review from asvetlov as a code owner April 11, 2024 15:17
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 11, 2024
Dreamsorcerer
Dreamsorcerer commented Apr 11, 2024
View reviewed changes
aiohttp/http_parser.py Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Apr 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (ffbc432) to head (1ea53e2).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8320   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files         107      107           
  Lines       33038    33045    +7     
  Branches     3875     3878    +3     
=======================================
+ Hits        32230    32237    +7     
  Misses        589      589           
  Partials      219      219
Flag Coverage Δ
CI-GHA 97.47% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.13% <100.00%> (+<0.01%) ⬆️
OS-Windows 95.57% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.79% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 95.42% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 96.93% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.13% <100.00%> (+<0.01%) ⬆️
Py-3.12.2 97.25% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 95.35% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.79% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 95.39% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 96.90% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.15 96.45% <100.00%> (+<0.01%) ⬆️
VM-macos 96.79% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.13% <100.00%> (+<0.01%) ⬆️
VM-windows 95.57% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 9ba9a4e into master Apr 11, 2024
37 of 38 checks passed
@Dreamsorcerer Dreamsorcerer deleted the should-close branch April 11, 2024 16:11
@patchback Patchback
Copy link
Contributor

patchback bot commented Apr 11, 2024 •
edited
Loading

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/9ba9a4e531599b9cb2f8cc80effbde40c7eab0bd/pr-8320

Backported as #8321

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 11, 2024
@Dreamsorcerer @patchback
Fix Python parser to mark responses without length as closing (#8320)
0936ebb 
(cherry picked from commit 9ba9a4e)
@patchback patchback bot mentioned this pull request Apr 11, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Apr 11, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/9ba9a4e531599b9cb2f8cc80effbde40c7eab0bd/pr-8320

Backported as #8322

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 11, 2024
@Dreamsorcerer @patchback
Fix Python parser to mark responses without length as closing (#8320)
c3af7ec 
(cherry picked from commit 9ba9a4e)
@patchback patchback bot mentioned this pull request Apr 11, 2024
Merged
Dreamsorcerer added a commit that referenced this pull request Apr 11, 2024
@patchback @Dreamsorcerer
[PR #8320/9ba9a4e5 backport][3.9] Fix Python parser to mark responses…
a7e240a 
… without length as closing (#8321)

**This is a backport of PR #8320 as merged into master
(9ba9a4e).**

Co-authored-by: Sam Bull <git@sambull.org>
Dreamsorcerer added a commit that referenced this pull request Apr 11, 2024
@patchback @Dreamsorcerer
[PR #8320/9ba9a4e5 backport][3.10] Fix Python parser to mark response…
68f1e41 
…s without length as closing (#8322)

**This is a backport of PR #8320 as merged into master
(9ba9a4e).**

Co-authored-by: Sam Bull <git@sambull.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Dreamsorcerer