-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TCPConnector doing blocking I/O in the event loop to create the SSLContext #8672
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8672 +/- ##
=======================================
Coverage 97.97% 97.98%
=======================================
Files 107 107
Lines 33794 33825 +31
Branches 3969 3969
=======================================
+ Hits 33110 33143 +33
+ Misses 507 505 -2
Partials 177 177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Sam Bull <git@sambull.org>
for more information, see https://pre-commit.ci
…nto fix_ssl_context_blocking_io
Needs tests for
|
…nto fix_ssl_context_blocking_io
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply c3219bf on top of patchback/backports/3.10/c3219bf88c2a9381c50cd18a0fc1ad701e39bb9a/pr-8672 Backporting merged PR #8672 into master
🤖 @patchback |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply c3219bf on top of patchback/backports/3.11/c3219bf88c2a9381c50cd18a0fc1ad701e39bb9a/pr-8672 Backporting merged PR #8672 into master
🤖 @patchback |
… in the event loop to create the SSLContext (#8673) Co-authored-by: Sam Bull <git@sambull.org> Co-authored-by: pre-commit-ci[bot]
… in the event loop to create the SSLContext (#8674) Co-authored-by: Sam Bull <git@sambull.org> Co-authored-by: pre-commit-ci[bot]
What do these changes do?
Create the SSLContext in the executor since it does blocking I/O to read the certificates from disk.
related issue #3080
Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no