Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks backported from #8701 #8717

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

Dreamsorcerer
Copy link
Member

No description provided.

@Dreamsorcerer Dreamsorcerer added bot:chronographer:skip This PR does not need to include a change note backport-3.10 labels Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (7cb7189) to head (121e9db).
Report is 630 commits behind head on 3.11.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #8717   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files         108      108           
  Lines       34075    34080    +5     
  Branches     4055     4056    +1     
=======================================
+ Hits        33288    33293    +5     
  Misses        587      587           
  Partials      200      200           
Flag Coverage Δ
CI-GHA 97.58% <90.90%> (-0.01%) ⬇️
OS-Linux 97.26% <90.90%> (-0.01%) ⬇️
OS-Windows 94.79% <90.90%> (-0.01%) ⬇️
OS-macOS 96.93% <90.90%> (-0.01%) ⬇️
Py-3.10.11 97.02% <81.81%> (-0.01%) ⬇️
Py-3.10.14 96.97% <81.81%> (-0.01%) ⬇️
Py-3.11.9 97.21% <72.72%> (-0.01%) ⬇️
Py-3.12.4 97.30% <72.72%> (-0.01%) ⬇️
Py-3.8.10 94.40% <81.81%> (-0.01%) ⬇️
Py-3.8.18 96.76% <81.81%> (-0.01%) ⬇️
Py-3.9.13 96.90% <81.81%> (-0.01%) ⬇️
Py-3.9.19 96.86% <81.81%> (-0.01%) ⬇️
Py-pypy7.3.16 96.45% <81.81%> (-0.01%) ⬇️
VM-macos 96.93% <90.90%> (-0.01%) ⬇️
VM-ubuntu 97.26% <90.90%> (-0.01%) ⬇️
VM-windows 94.79% <90.90%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit e0a7c0c into 3.11 Aug 16, 2024
33 of 34 checks passed
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-4 branch August 16, 2024 16:26
Copy link
Contributor

patchback bot commented Aug 16, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/e0a7c0cb7131ce45265157be5caa683ed57d24a7/pr-8717

Backported as #8719

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 16, 2024
Dreamsorcerer added a commit that referenced this pull request Aug 16, 2024
…#8719)

**This is a backport of PR #8717 as merged into 3.11
(e0a7c0c).**

Co-authored-by: Sam Bull <git@sambull.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant