Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Request.__repr__ #875

Closed
sametmax opened this issue May 13, 2016 · 1 comment
Closed

Improve Request.__repr__ #875

sametmax opened this issue May 13, 2016 · 1 comment

Comments

@sametmax
Copy link

sametmax commented May 13, 2016

Url can now contains unicode caracters, so:

def __repr__(self):
    return "<{} {} {} >".format(self.__class__.__name__,
                                self.method, self.path)

Will break as repr() expects ASCII chars.

To avoid this problem, use !r:

def __repr__(self):
    return "<{} {} {!r} >".format(self.__class__.__name__,
                                self.method, self.path)

You may also want to add the POST parameters in the repr to be even more debug friendly. This would however require to limit the number of keys displayed and their content in size.

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants