repr only returns ascii encodable characters #899

boylea · 2016-06-02T21:29:52Z

What these changes does?

Request.__repr__ and ClientResponse.__repr__ now only contain ascii-encodable characters

Some of the formatting looks pretty gross, but this is how I got it to pass flake8, open to suggestions on how to make it better

I added a test for each case

Solves #875

coveralls · 2016-06-02T21:49:10Z

Coverage increased (+0.001%) to 98.215% when pulling 120c2e9 on boylea:repr-encoding into c059e0b on KeepSafe:master.

asvetlov · 2016-06-03T00:19:08Z

Thanks!

lock · 2019-10-29T18:04:46Z

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

boylea added 2 commits June 2, 2016 12:57

Request.__repr__ only returns ascii characters

2e7117f

ClientResponse.__repr__ only returns ascii characters

120c2e9

boylea force-pushed the repr-encoding branch from 207fcb5 to 120c2e9 Compare June 2, 2016 21:44

asvetlov merged commit 21241bb into aio-libs:master Jun 3, 2016

lock bot added the outdated label Oct 29, 2019

lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019