Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a create_future compatibility wrapper instead of creating Futures directly #896

Merged
merged 3 commits into from
Jun 2, 2016

Conversation

jchampio
Copy link
Contributor

@jchampio jchampio commented Jun 2, 2016

What these changes does?

Adds the create_future compat wrapper (and tests) discussed at the PyCon 2016 sprint.

How to test your changes?

The make test suite includes mock tests to ensure the wrapper is functioning.

Related issue number

Issue #893

Checklist

  • Code is written and well
  • Tests for the changes are provided
  • Documentation reflects the changes (not sure if this is applicable?)

Apply the asyncio.Future() -> helpers.create_future() refactoring to the
tests as well.
@asvetlov asvetlov merged commit 051d36f into aio-libs:master Jun 2, 2016
@jchampio jchampio deleted the dev/create_future branch June 3, 2016 00:22
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants