Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Generic for TestClient.app #8977

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Sep 1, 2024

This should avoid annoying assert client.app is not None lines in test code.

Fixes #7226.

@Dreamsorcerer Dreamsorcerer added the backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot label Sep 1, 2024
CHANGES/8977.bugfix.rst Outdated Show resolved Hide resolved
aiohttp/pytest_plugin.py Dismissed Show dismissed Hide dismissed
aiohttp/pytest_plugin.py Dismissed Show dismissed Hide dismissed
aiohttp/pytest_plugin.py Dismissed Show dismissed Hide dismissed
aiohttp/pytest_plugin.py Dismissed Show dismissed Hide dismissed
aiohttp/test_utils.py Dismissed Show dismissed Hide dismissed
aiohttp/test_utils.py Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.28%. Comparing base (f569894) to head (d1d88a2).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8977   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         107      107           
  Lines       34287    34295    +8     
  Branches     4062     4065    +3     
=======================================
+ Hits        33699    33707    +8     
  Misses        415      415           
  Partials      173      173           
Flag Coverage Δ
CI-GHA 98.17% <83.33%> (-0.01%) ⬇️
OS-Linux 97.83% <83.33%> (-0.01%) ⬇️
OS-Windows 96.24% <83.33%> (-0.01%) ⬇️
OS-macOS 97.51% <83.33%> (-0.01%) ⬇️
Py-3.10.11 97.59% <66.66%> (-0.02%) ⬇️
Py-3.10.14 97.52% <66.66%> (-0.02%) ⬇️
Py-3.11.9 97.76% <83.33%> (-0.01%) ⬇️
Py-3.12.5 97.88% <83.33%> (-0.01%) ⬇️
Py-3.9.13 97.48% <66.66%> (-0.02%) ⬇️
Py-3.9.19 97.42% <66.66%> (-0.02%) ⬇️
Py-pypy7.3.16 97.03% <66.66%> (-0.02%) ⬇️
VM-macos 97.51% <83.33%> (-0.01%) ⬇️
VM-ubuntu 97.83% <83.33%> (-0.01%) ⬇️
VM-windows 96.24% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestClient.app can be None
1 participant