Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8933/8f3b1f44 backport][3.11] Small cleanups to the websocket frame sender #8979

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Sep 1, 2024

This is a backport of PR #8933 as merged into master (8f3b1f4).

What do these changes do?

  • Add some comments about what is going on in _send_frame
  • Avoid fetch the len() in a few places where its a fixed value and already known

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (be27f79) to head (7a677aa).
Report is 565 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #8979   +/-   ##
=======================================
  Coverage   97.74%   97.74%           
=======================================
  Files         108      108           
  Lines       34435    34438    +3     
  Branches     4085     4084    -1     
=======================================
+ Hits        33658    33661    +3     
  Misses        581      581           
  Partials      196      196           
Flag Coverage Δ
CI-GHA 97.64% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.31% <100.00%> (-0.01%) ⬇️
OS-Windows 94.88% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.00% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.09% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 97.03% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.25% <100.00%> (+<0.01%) ⬆️
Py-3.12.5 97.36% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.00% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 96.94% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.53% <100.00%> (+<0.01%) ⬆️
VM-macos 97.00% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.31% <100.00%> (-0.01%) ⬇️
VM-windows 94.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) September 1, 2024 23:36
@bdraco bdraco merged commit 2af23ab into 3.11 Sep 1, 2024
28 of 29 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/8f3b1f445ab481a928795577ae0132a04696f4af/pr-8933 branch September 1, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant