Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more info to add_static() warning #8983

Merged
merged 2 commits into from
Sep 22, 2024
Merged

Add more info to add_static() warning #8983

merged 2 commits into from
Sep 22, 2024

Conversation

Dreamsorcerer
Copy link
Member

Fixes #7232.

@Dreamsorcerer Dreamsorcerer added backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Sep 2, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.42%. Comparing base (7b11e23) to head (bcabb2c).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8983   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files         107      107           
  Lines       34658    34658           
  Branches     4105     4105           
=======================================
  Hits        34111    34111           
  Misses        380      380           
  Partials      167      167
Flag Coverage Δ
CI-GHA 98.31% <ø> (ø)
OS-Linux 97.98% <ø> (ø)
OS-Windows 96.40% <ø> (ø)
OS-macOS 97.65% <ø> (ø)
Py-3.10.11 97.75% <ø> (ø)
Py-3.10.15 97.69% <ø> (ø)
Py-3.11.10 97.58% <ø> (ø)
Py-3.11.9 97.64% <ø> (ø)
Py-3.12.6 98.03% <ø> (ø)
Py-3.9.13 97.64% <ø> (ø)
Py-3.9.20 97.58% <ø> (ø)
Py-pypy7.3.16 97.19% <ø> (ø)
VM-macos 97.65% <ø> (ø)
VM-ubuntu 97.98% <ø> (ø)
VM-windows 96.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Sep 22, 2024
@bdraco bdraco enabled auto-merge (squash) September 22, 2024 15:44
@bdraco bdraco merged commit ceb7ae5 into master Sep 22, 2024
33 of 34 checks passed
@bdraco bdraco deleted the Dreamsorcerer-patch-4 branch September 22, 2024 15:54
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 22, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/ceb7ae518d696b24e72203f9affe6ef6d1542e69/pr-8983

Backported as #9229

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 22, 2024
@Dreamsorcerer @patchback
Add more info to add_static() warning (#8983)
f4f85a5 
Co-authored-by: J. Nick Koston <nick@koston.org>
(cherry picked from commit ceb7ae5)
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 22, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/ceb7ae518d696b24e72203f9affe6ef6d1542e69/pr-8983

Backported as #9230

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Sep 22, 2024
Merged
patchback bot pushed a commit that referenced this pull request Sep 22, 2024
@Dreamsorcerer @patchback
Add more info to add_static() warning (#8983)
3a5c26d 
Co-authored-by: J. Nick Koston <nick@koston.org>
(cherry picked from commit ceb7ae5)
@patchback patchback bot mentioned this pull request Sep 22, 2024
Merged
bdraco pushed a commit that referenced this pull request Sep 22, 2024
@patchback
[PR #8983/ceb7ae51 backport][3.10] Add more info to add_static() warn…
16b4bc4 
…ing (#9229)

Co-authored-by: Sam Bull <git@sambull.org>
Fixes #7232.
bdraco pushed a commit that referenced this pull request Sep 22, 2024
@patchback
[PR #8983/ceb7ae51 backport][3.11] Add more info to add_static() warn…
75459a5 
…ing (#9230)

Co-authored-by: Sam Bull <git@sambull.org>
Fixes #7232.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdraco bdraco bdraco approved these changes

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify add_static warning in documentation.
2 participants
@Dreamsorcerer @bdraco