-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add proxy and proxy_auth varriables to ClientSession.__init__ #9207
Conversation
…t in _request function
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9207 +/- ##
=======================================
Coverage 98.55% 98.55%
=======================================
Files 107 107
Lines 34867 34896 +29
Branches 4134 4138 +4
=======================================
+ Hits 34364 34393 +29
Misses 335 335
Partials 168 168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Seems reasonable, but please resolve coverage. |
Ok, I try fix it today |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 970c5d9 on top of patchback/backports/3.11/970c5d9d84afc8fb762ff04940b5e25449a1f6ae/pr-9207 Backporting merged PR #9207 into master
🤖 @patchback |
Thanks, if you could do the backport as above, that'd be a great help. |
Thanks for merge, I appreciate your time and effort, I'll do the backport soon. |
What do these changes do?
Users are now able to set
proxy
andproxy_auth
as defaults inClientSession.__init__
.Are there changes in behavior for the user?
No, there is not
These changes will not affect applications written with previous versions of aiohttp.
However, they can now set default proxy settings when creating an instance of
ClientSession
.NOTICE: If default settings are set and then a new proxy setting is specified in
SessionClient.get
(orpost
, etc.), the latter will take effect.Is it a substantial burden for the maintainers to support this?
It is a simple patch and should not cause any issues.
Related issue number
Checklist
CONTRIBUTORS.txt
CHANGES/
foldername it
<issue_or_pr_num>.<type>.rst
(e.g.588.bugfix.rst
)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix
: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature
: A new behavior, public APIs. That sort of stuff..deprecation
: A declaration of future API removals and breakingchanges in behavior.
.breaking
: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc
: Notable updates to the documentation structure or buildprocess.
.packaging
: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib
: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc
: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.