Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dns resolution task eagerly on python 3.12+ #9343

Merged
merged 2 commits into from
Sep 29, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 29, 2024

What do these changes do?

DNS resolution may be able to happen synchronously if the host is already known. Effectively the same change as #8661

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

DNS resolution may be able to happen synchronously if
the host is already known
aiohttp/connector.py Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.56%. Comparing base (8a97e03) to head (ba48fe2).
Report is 731 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9343   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files         107      107           
  Lines       34942    34947    +5     
  Branches     4145     4147    +2     
=======================================
+ Hits        34439    34444    +5     
  Misses        335      335           
  Partials      168      168           
Flag Coverage Δ
CI-GHA 98.44% <87.50%> (-0.01%) ⬇️
OS-Linux 98.10% <87.50%> (-0.01%) ⬇️
OS-Windows 96.51% <87.50%> (-0.01%) ⬇️
OS-macOS 97.78% <87.50%> (-0.01%) ⬇️
Py-3.10.11 97.66% <62.50%> (-0.01%) ⬇️
Py-3.10.15 97.60% <62.50%> (-0.01%) ⬇️
Py-3.11.10 97.66% <62.50%> (-0.01%) ⬇️
Py-3.11.9 97.73% <62.50%> (-0.01%) ⬇️
Py-3.12.6 98.15% <75.00%> (-0.02%) ⬇️
Py-3.13.0-rc.2 98.13% <75.00%> (-0.02%) ⬇️
Py-3.9.13 97.56% <62.50%> (-0.01%) ⬇️
Py-3.9.20 97.50% <62.50%> (-0.01%) ⬇️
Py-pypy7.3.16 97.12% <62.50%> (-0.01%) ⬇️
VM-macos 97.78% <87.50%> (-0.01%) ⬇️
VM-ubuntu 98.10% <87.50%> (-0.01%) ⬇️
VM-windows 96.51% <87.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco added backport-3.10 backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Sep 29, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 29, 2024
@bdraco bdraco marked this pull request as ready for review September 29, 2024 15:09
@bdraco bdraco merged commit 5762ed6 into master Sep 29, 2024
39 of 40 checks passed
@bdraco bdraco deleted the eager_start_dns branch September 29, 2024 15:28
Copy link
Contributor

patchback bot commented Sep 29, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/5762ed61c64feccb239d7dc025c36ede3a9cf118/pr-9343

Backported as #9345

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Sep 29, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/5762ed61c64feccb239d7dc025c36ede3a9cf118/pr-9343

Backported as #9346

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 29, 2024
bdraco added a commit that referenced this pull request Sep 29, 2024
… on python 3.12+ (#9345)

Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco added a commit that referenced this pull request Sep 29, 2024
… on python 3.12+ (#9346)

Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant