-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create dns resolution task eagerly on python 3.12+ #9343
Conversation
DNS resolution may be able to happen synchronously if the host is already known
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9343 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 107 107
Lines 34942 34947 +5
Branches 4145 4147 +2
=======================================
+ Hits 34439 34444 +5
Misses 335 335
Partials 168 168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #9345 🤖 @patchback |
(cherry picked from commit 5762ed6)
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9346 🤖 @patchback |
(cherry picked from commit 5762ed6)
… on python 3.12+ (#9345) Co-authored-by: J. Nick Koston <nick@koston.org>
… on python 3.12+ (#9346) Co-authored-by: J. Nick Koston <nick@koston.org>
What do these changes do?
DNS resolution may be able to happen synchronously if the host is already known. Effectively the same change as #8661
Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no