Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8456/b09d7cc backport][3.10] Add ClientConnectorDNSError for differentiating DNS errors from others #9459

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 10, 2024

Co-authored-by: J. Nick Koston nick@koston.org
(cherry picked from commit b09d7cc)

#8456)

Co-authored-by: J. Nick Koston <nick@koston.org>
(cherry picked from commit b09d7cc)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 10, 2024
@bdraco bdraco changed the title Add ClientConnectorDNSError for differentiating DNS errors from others (#8456) [PR #8456/b09d7cc backport][3.10] Add ClientConnectorDNSError for differentiating DNS errors from others Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.82%. Comparing base (cdf3dca) to head (dece0db).
Report is 1 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #9459   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files         106      106           
  Lines       35046    35063   +17     
  Branches     4216     4219    +3     
=======================================
+ Hits        34282    34299   +17     
  Misses        568      568           
  Partials      196      196           
Flag Coverage Δ
CI-GHA 97.70% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.39% <100.00%> (-0.01%) ⬇️
OS-Windows 94.93% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.08% <100.00%> (-0.01%) ⬇️
Py-3.10.11 96.95% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 96.88% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 96.97% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.03% <100.00%> (-0.02%) ⬇️
Py-3.12.7 97.43% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 97.41% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 94.32% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.68% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.86% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 96.80% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.40% <100.00%> (+<0.01%) ⬆️
VM-macos 97.08% <100.00%> (-0.01%) ⬇️
VM-ubuntu 97.39% <100.00%> (-0.01%) ⬇️
VM-windows 94.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review October 10, 2024 18:51
@bdraco bdraco enabled auto-merge (squash) October 10, 2024 18:51
@bdraco bdraco merged commit 8b424c8 into 3.10 Oct 10, 2024
35 of 36 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/b09d7cc07607d01badf8051f5b8feb2a2ed070c8/pr-8456 branch October 10, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants