Avoid passing client writer to response when already finished #9485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Python 3.12+ its likely that the writer can finish synchronously. In this case avoid passing it to the response since it will get unset right away needlessly
bdraco
added
backport-3.10
backport-3.11
With Python 3.12+ its likely that the writer can finish synchronously. In this case avoid passing it to the response since it will get unset right away needlessly
bdraco
changed the title
bdraco
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9485 +/- ##
==========================================
- Coverage 98.59% 98.59% -0.01%
==========================================
Files 105 105
Lines 35094 35093 -1
Branches 4179 4179
==========================================
- Hits 34601 34600 -1
Misses 329 329
Partials 164 164
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
commented
Oct 15, 2024
psf-chronographer
bot
added
the
bot:chronographer:provided
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #9492 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
(cherry picked from commit da0099d)
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9493 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
(cherry picked from commit da0099d)
bdraco
added a commit
that referenced
this pull request
Oct 16, 2024
…ponse when already finished (#9492) Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco
added a commit
that referenced
this pull request
Oct 16, 2024
…ponse when already finished (#9493) Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
With Python 3.12+ its likely that the writer can finish synchronously (on a production HA instance, it always did for all samples in a 60s period). In this case avoid passing it to the response since it will get unset right away needlessly
Are there changes in behavior for the user?
no