Improve performance of creating the ConnectionKey #9499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reuses the same idea as aio-libs/yarl#1316 and aio-libs/yarl#1322 Calling `tuple.__new__` is much faster because it avoids the extra runtime lambda having to be run and arguments unpacked for every message https://github.com/python/cpython/blob/d83fcf8371f2f33c7797bc8f5423a8bca8c46e5c/Lib/collections/__init__.py#L441 This only works if the object being created is a `NamedTuple` so this speed up is only recommended internally and should not be used outside of `aiohttp` since we do not guarantee that ConnectionKey will remain a `NamedTuple` in the future.
bdraco
added
bot:chronographer:skip
|
Can only backport to 3.11 since |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9499 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 105 105
Lines 35093 35093
Branches 4179 4179
=======================================
Hits 34600 34600
Misses 329 329
Partials 164 164
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9500 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
(cherry picked from commit b45a7da)
bdraco
added a commit
that referenced
this pull request
Oct 18, 2024
…e ConnectionKey (#9500) Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Improve performance of the client by reducing the overhead to create the
ConnectionKeyobjects.Reuses the same idea as aio-libs/yarl#1316 and aio-libs/yarl#1322
Calling
tuple.__new__is much faster because it avoids the extra runtime lambda having to be run and arguments unpacked for every message https://github.com/python/cpython/blob/d83fcf8371f2f33c7797bc8f5423a8bca8c46e5c/Lib/collections/__init__.py#L441This only works if the object being created is a
NamedTupleso this speed up is only recommended internally and should not be used outside ofaiohttpsince we do not guarantee that ConnectionKey will remain aNamedTuplein the future.Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no