Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codspeed benchmarks #9534

Merged
merged 9 commits into from
Oct 25, 2024
Merged

Add codspeed benchmarks #9534

merged 9 commits into from
Oct 25, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 24, 2024

What do these changes do?

Adds codspeed benchmarks

This will get the ball rolling so we know when we have solved #9520

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

This will get the ball rolling so we know
when we have solved #9520
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Oct 24, 2024
Copy link

codspeed-hq bot commented Oct 24, 2024

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 2 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

  • test_client_request_update_cookies[pyloop] (176.8 µs)
  • test_load_cookies_into_temp_cookiejar (210.3 µs)

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.59%. Comparing base (0458c14) to head (19e6bd3).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9534      +/-   ##
==========================================
+ Coverage   97.83%   98.59%   +0.76%     
==========================================
  Files         103      107       +4     
  Lines       35035    35131      +96     
  Branches     4152     4180      +28     
==========================================
+ Hits        34277    34639     +362     
+ Misses        558      329     -229     
+ Partials      200      163      -37     
Flag Coverage Δ
CI-GHA 98.48% <100.00%> (+0.72%) ⬆️
OS-Linux 98.14% <100.00%> (?)
OS-Windows 96.53% <100.00%> (?)
OS-macOS 97.84% <100.00%> (+0.08%) ⬆️
Py-3.10.11 97.71% <100.00%> (+0.31%) ⬆️
Py-3.10.15 97.63% <100.00%> (?)
Py-3.11.10 97.70% <100.00%> (?)
Py-3.11.9 97.78% <100.00%> (?)
Py-3.12.7 98.20% <100.00%> (+0.58%) ⬆️
Py-3.13.0 98.18% <100.00%> (?)
Py-3.9.13 97.60% <100.00%> (?)
Py-3.9.20 97.54% <100.00%> (?)
Py-pypy7.3.16 97.17% <100.00%> (?)
VM-macos 97.84% <100.00%> (+0.08%) ⬆️
VM-ubuntu 98.14% <100.00%> (?)
VM-windows 96.53% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco closed this Oct 24, 2024
@bdraco bdraco reopened this Oct 24, 2024
@bdraco bdraco marked this pull request as ready for review October 24, 2024 21:38
@bdraco bdraco changed the title Adds codspeed benchmarks Add codspeed benchmarks Oct 25, 2024
@bdraco bdraco merged commit 5a79c0f into master Oct 25, 2024
40 of 41 checks passed
@bdraco bdraco deleted the benchmarks branch October 25, 2024 21:56
Copy link
Contributor

patchback bot commented Oct 25, 2024

Backport to 3.10: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 5a79c0f on top of patchback/backports/3.10/5a79c0f361129f6276a892bf81eed92f22b729d8/pr-9534

Backporting merged PR #9534 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.10/5a79c0f361129f6276a892bf81eed92f22b729d8/pr-9534 upstream/3.10
  4. Now, cherry-pick PR Add codspeed benchmarks #9534 contents into that branch:
    $ git cherry-pick -x 5a79c0f361129f6276a892bf81eed92f22b729d8
    If it'll yell at you with something like fatal: Commit 5a79c0f361129f6276a892bf81eed92f22b729d8 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 5a79c0f361129f6276a892bf81eed92f22b729d8
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Add codspeed benchmarks #9534 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.10/5a79c0f361129f6276a892bf81eed92f22b729d8/pr-9534
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Oct 25, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/5a79c0f361129f6276a892bf81eed92f22b729d8/pr-9534

Backported as #9536

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 25, 2024
(cherry picked from commit 5a79c0f)
bdraco added a commit that referenced this pull request Oct 25, 2024
(cherry picked from commit 5a79c0f)
bdraco added a commit that referenced this pull request Oct 25, 2024
Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants