-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNM: Experiment to speed up creating cookie morsels #9594
Conversation
This likely needs to be optimized upstream
CodSpeed Performance ReportMerging #9594 will improve performances by 12.91%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9594 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 113 113
Lines 35284 35305 +21
Branches 4187 4189 +2
=======================================
+ Hits 34799 34820 +21
Misses 325 325
Partials 160 160
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It's a really simple optimization. The loop can be replaced with a dict update upstream. |
This likely needs to be optimized upstream but we can get an idea if its worth it here