Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify header and method lookups #9722

Merged
merged 8 commits into from
Nov 9, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 9, 2024

Replace method_must_be_empty_body and status_code_must_be_empty_body with a simple set constant, and avoid many .upper() calls

~2% speed up
Screenshot 2024-11-09 at 9 18 18 AM

This function can be replaced with a simple set lookup
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Nov 9, 2024
Copy link

codspeed-hq bot commented Nov 9, 2024

CodSpeed Performance Report

Merging #9722 will not alter performance

Comparing status_code_must_be_empty_body (32998b0) with master (500a021)

Summary

✅ 14 untouched benchmarks

This function can be replaced with a simple set lookup
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (500a021) to head (32998b0).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9722   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files         117      117           
  Lines       35787    35787           
  Branches     4239     4239           
=======================================
  Hits        35313    35313           
  Misses        319      319           
  Partials      155      155           
Flag Coverage Δ
CI-GHA 98.56% <100.00%> (ø)
OS-Linux 98.23% <100.00%> (ø)
OS-Windows 95.99% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.30% <100.00%> (ø)
Py-3.10.11 97.16% <100.00%> (ø)
Py-3.10.15 97.71% <100.00%> (ø)
Py-3.11.10 97.77% <100.00%> (ø)
Py-3.11.9 97.23% <100.00%> (-0.01%) ⬇️
Py-3.12.7 98.26% <100.00%> (ø)
Py-3.13.0 98.25% <100.00%> (ø)
Py-3.9.13 97.08% <100.00%> (ø)
Py-3.9.20 97.63% <100.00%> (ø)
Py-pypy7.3.16 97.25% <100.00%> (-0.01%) ⬇️
VM-macos 97.30% <100.00%> (ø)
VM-ubuntu 98.23% <100.00%> (ø)
VM-windows 95.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco changed the title Simplify status_code_must_be_empty_body Simplify header and method lookups Nov 9, 2024
@bdraco bdraco marked this pull request as ready for review November 9, 2024 10:03
@bdraco bdraco requested a review from asvetlov as a code owner November 9, 2024 10:03
@bdraco bdraco requested a review from webknjaz as a code owner November 9, 2024 10:04
CHANGES/9722.misc.rst Outdated Show resolved Hide resolved
@bdraco bdraco merged commit fbf555c into master Nov 9, 2024
40 of 41 checks passed
@bdraco bdraco deleted the status_code_must_be_empty_body branch November 9, 2024 11:14
Copy link
Contributor

patchback bot commented Nov 9, 2024

Backport to 3.11: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply fbf555c on top of patchback/backports/3.11/fbf555c368d1b5df3deeea9538a5fe7659afeb10/pr-9722

Backporting merged PR #9722 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.11/fbf555c368d1b5df3deeea9538a5fe7659afeb10/pr-9722 upstream/3.11
  4. Now, cherry-pick PR Simplify header and method lookups #9722 contents into that branch:
    $ git cherry-pick -x fbf555c368d1b5df3deeea9538a5fe7659afeb10
    If it'll yell at you with something like fatal: Commit fbf555c368d1b5df3deeea9538a5fe7659afeb10 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x fbf555c368d1b5df3deeea9538a5fe7659afeb10
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Simplify header and method lookups #9722 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.11/fbf555c368d1b5df3deeea9538a5fe7659afeb10/pr-9722
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

bdraco added a commit that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant