-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify header and method lookups #9722
Conversation
This function can be replaced with a simple set lookup
CodSpeed Performance ReportMerging #9722 will not alter performanceComparing Summary
|
This function can be replaced with a simple set lookup
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9722 +/- ##
=======================================
Coverage 98.67% 98.67%
=======================================
Files 117 117
Lines 35787 35787
Branches 4239 4239
=======================================
Hits 35313 35313
Misses 319 319
Partials 155 155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply fbf555c on top of patchback/backports/3.11/fbf555c368d1b5df3deeea9538a5fe7659afeb10/pr-9722 Backporting merged PR #9722 into master
🤖 @patchback |
(cherry picked from commit fbf555c)
Replace
method_must_be_empty_body
andstatus_code_must_be_empty_body
with a simple set constant, and avoid many.upper()
calls~2% speed up