Fix #976: Add support for websocket send_json and receive_json #984

vitaliemaldur · 2016-07-23T09:18:27Z

What do these changes do?

Add support for websocket server to send json and for websocket client to send and receive json

Are there changes in behavior for the user?

User can use methods:
send_json and receive_json both on websocket server and client

Related issue number

#976

Checklist

I think the code is well written
Unit tests for the changes exist
Documentation reflects the changes

coveralls · 2016-07-23T09:20:53Z

Coverage decreased (-0.2%) to 97.803% when pulling 7fb73d0 on vitaliemaldur:master into 328bb36 on KeepSafe:master.

asvetlov · 2016-07-23T09:39:22Z

aiohttp/web_ws.py

@@ -154,6 +154,13 @@ def send_bytes(self, data):
                            type(data))
        self._writer.send(data, binary=True)

+    def send_json(self, data, *, dumps=json.dumps):


Please call .send_str() instead of working on low level.

asvetlov · 2016-07-23T09:40:55Z

Would you add tests also?

vitaliemaldur · 2016-07-23T09:50:39Z

Yes I will

…json

coveralls · 2016-07-23T11:42:17Z

Coverage decreased (-0.1%) to 97.864% when pulling 611a286 on vitaliemaldur:master into 328bb36 on KeepSafe:master.

vitaliemaldur · 2016-07-23T11:51:07Z

@asvetlov what I can do to avoid

AttributeError: 'module' object has no attribute 'JSONDecodeError'
tests\test_web_websocket.py:161: AttributeError

I am using json.decoder.JSONDecodeError in a try/except.

Also, do you have some suggestions for the tests I wrote?

asvetlov · 2016-07-23T12:28:14Z

aiohttp/web_ws.py

@@ -154,6 +154,13 @@ def send_bytes(self, data):
                            type(data))
        self._writer.send(data, binary=True)

+    def send_json(self, data, *, dumps=json.dumps):
+        if self._writer is None:


These checks are not required: .send_str() performs them anyway.
There is no need to do the check twice.

vitaliemaldur · 2016-07-23T14:57:21Z

@asvetlov I've noticed that in web_ws.py we have send_str, send_bytes, send_json methods and coresponding receive_str, receive_bytes, receive_json. But in websocket_client.py we have send_str, send_bytes, send_json methods and only receive_json. Is that on purpose? or should I add the rest of methods there?

asvetlov · 2016-07-23T15:01:44Z

I think yes.
From my perspective we should support the same methods for both client and server for consistency.

…ceive_json

coveralls · 2016-07-23T15:54:01Z

Coverage decreased (-0.04%) to 97.945% when pulling 66c2c00 on vitaliemaldur:master into 328bb36 on KeepSafe:master.

… receive_json

coveralls · 2016-07-23T16:52:20Z

Coverage decreased (-0.04%) to 97.945% when pulling 524669e on vitaliemaldur:master into 328bb36 on KeepSafe:master.

coveralls · 2016-07-23T17:27:38Z

Coverage decreased (-0.008%) to 97.974% when pulling 8fd4aa9 on vitaliemaldur:master into 328bb36 on KeepSafe:master.

vitaliemaldur · 2016-07-23T17:40:03Z

@asvetlov I have added all the methods discussed above, now we have:

send_str
send_bytes
send_json
receive_str
receive_bytes
receive_json

both on websocket_client.py and web_ws.py. I have also added documentation for them.

asvetlov · 2016-07-24T14:17:38Z

Thanks!

lock · 2019-10-29T17:03:39Z

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

Fix aio-libs#976: Add support for websocket send_json and receive_json

7fb73d0

asvetlov reviewed Jul 23, 2016
View reviewed changes

asvetlov added the sprint label Jul 23, 2016

Vitalie Maldur added 2 commits July 23, 2016 13:15

Fix for (aio-libs#976): use send_str instead of low level send method

d5d95c8

Fix for (aio-libs#976): add test for websocket send_json and receive_…

611a286

…json

asvetlov reviewed Jul 23, 2016
View reviewed changes

Vitalie Maldur added 2 commits July 23, 2016 17:41

Fix for (aio-libs#976): refactor websocket send_json and receive_json

9b04034

Fix for (aio-libs#976): refactor tests for websocket send_json and re…

66c2c00

…ceive_json

Fix for (aio-libs#976): add documentation for websocket send_json and…

524669e

… receive_json

Vitalie Maldur added 2 commits July 23, 2016 19:19

Fix for (aio-libs#976): serialize receive_str response in receive_json

44bd7c3

Fix for (aio-libs#976): refactor docs for receive_json method

8fd4aa9

asvetlov merged commit 2488b85 into aio-libs:master Jul 24, 2016

lock bot added the outdated label Oct 29, 2019

lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #976: Add support for websocket send_json and receive_json #984

Fix #976: Add support for websocket send_json and receive_json #984

vitaliemaldur commented Jul 23, 2016 •

edited

Loading

coveralls commented Jul 23, 2016 •

edited

Loading

asvetlov Jul 23, 2016 •

edited

Loading

asvetlov commented Jul 23, 2016

vitaliemaldur commented Jul 23, 2016 •

edited

Loading

coveralls commented Jul 23, 2016 •

edited

Loading

vitaliemaldur commented Jul 23, 2016

asvetlov Jul 23, 2016

vitaliemaldur commented Jul 23, 2016 •

edited

Loading

asvetlov commented Jul 23, 2016

coveralls commented Jul 23, 2016 •

edited

Loading

coveralls commented Jul 23, 2016 •

edited

Loading

coveralls commented Jul 23, 2016 •

edited

Loading

vitaliemaldur commented Jul 23, 2016

asvetlov commented Jul 24, 2016

lock bot commented Oct 29, 2019

Fix #976: Add support for websocket send_json and receive_json #984

Fix #976: Add support for websocket send_json and receive_json #984

Conversation

vitaliemaldur commented Jul 23, 2016 • edited Loading

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

coveralls commented Jul 23, 2016 • edited Loading

asvetlov Jul 23, 2016 • edited Loading

Choose a reason for hiding this comment

asvetlov commented Jul 23, 2016

vitaliemaldur commented Jul 23, 2016 • edited Loading

coveralls commented Jul 23, 2016 • edited Loading

vitaliemaldur commented Jul 23, 2016

asvetlov Jul 23, 2016

Choose a reason for hiding this comment

vitaliemaldur commented Jul 23, 2016 • edited Loading

asvetlov commented Jul 23, 2016

coveralls commented Jul 23, 2016 • edited Loading

coveralls commented Jul 23, 2016 • edited Loading

coveralls commented Jul 23, 2016 • edited Loading

vitaliemaldur commented Jul 23, 2016

asvetlov commented Jul 24, 2016

lock bot commented Oct 29, 2019

vitaliemaldur commented Jul 23, 2016 •

edited

Loading

coveralls commented Jul 23, 2016 •

edited

Loading

asvetlov Jul 23, 2016 •

edited

Loading

vitaliemaldur commented Jul 23, 2016 •

edited

Loading

coveralls commented Jul 23, 2016 •

edited

Loading

vitaliemaldur commented Jul 23, 2016 •

edited

Loading

coveralls commented Jul 23, 2016 •

edited

Loading

coveralls commented Jul 23, 2016 •

edited

Loading

coveralls commented Jul 23, 2016 •

edited

Loading