Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove __author__ from __dir__ #9918

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Remove __author__ from __dir__ #9918

merged 3 commits into from
Nov 15, 2024

Conversation

Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Nov 15, 2024

We don't actually define this. This was a mistake I made a few years ago in #6591.

Fixes #9914.

@Dreamsorcerer Dreamsorcerer added backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Nov 15, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 15, 2024
Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #9918 will not alter performance

Comparing Dreamsorcerer-patch-1 (e25d18b) with master (4a9bbf9)

Summary

✅ 32 untouched benchmarks

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (4a9bbf9) to head (e25d18b).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9918   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files         120      120           
  Lines       36473    36473           
  Branches     4342     4342           
=======================================
  Hits        36005    36005           
  Misses        315      315           
  Partials      153      153           
Flag Coverage Δ
CI-GHA 98.60% <100.00%> (ø)
OS-Linux 98.29% <100.00%> (ø)
OS-Windows 96.10% <ø> (ø)
OS-macOS 97.38% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.23% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.78% <100.00%> (ø)
Py-3.11.10 97.82% <100.00%> (ø)
Py-3.11.9 97.28% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 98.35% <100.00%> (ø)
Py-3.13.0 98.35% <100.00%> (ø)
Py-3.9.13 97.15% <100.00%> (ø)
Py-3.9.20 97.74% <100.00%> (ø)
Py-pypy7.3.16 97.30% <100.00%> (ø)
VM-macos 97.38% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.29% <100.00%> (ø)
VM-windows 96.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGES/9918.bugfix.rst Outdated Show resolved Hide resolved
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <sviat@redhat.com>
@Dreamsorcerer Dreamsorcerer enabled auto-merge (squash) November 15, 2024 20:06
@Dreamsorcerer Dreamsorcerer merged commit 6ada273 into master Nov 15, 2024
39 of 40 checks passed
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-1 branch November 15, 2024 20:17
Copy link
Contributor

patchback bot commented Nov 15, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/6ada2737485af65c7df8089b1c66c56e38da2bcd/pr-9918

Backported as #9919

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 15, 2024
Copy link
Contributor

patchback bot commented Nov 15, 2024

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/6ada2737485af65c7df8089b1c66c56e38da2bcd/pr-9918

Backported as #9920

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 15, 2024
Dreamsorcerer added a commit that referenced this pull request Nov 16, 2024
)

**This is a backport of PR #9918 as merged into master
(6ada273).**

Co-authored-by: Sam Bull <git@sambull.org>
Dreamsorcerer added a commit that referenced this pull request Nov 16, 2024
)

**This is a backport of PR #9918 as merged into master
(6ada273).**

Co-authored-by: Sam Bull <git@sambull.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aiohttp fails with module aiohttp has no attribute __author__
3 participants