Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IE support for cookie deletion. #994

Merged
merged 5 commits into from
Jul 23, 2016
Merged

Add IE support for cookie deletion. #994

merged 5 commits into from
Jul 23, 2016

Conversation

aleksey-kutepov
Copy link
Contributor

What do these changes do?

Adds support for IE cookie expiration.

Are there changes in behavior for the user?

Not unless they are deleting cookies, otherwise they will actually delete on IE!

Related issue number

PR #996.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

SethMichaelLarson and others added 4 commits July 15, 2016 12:02
@SethMichaelLarson
Add IE support for cookie deletion.
e1dd118 
IE<=11 ( !!! ) doesn't support the MaxAge property for cookies so del_cookie() also needs to set the Expires cookie header to support IE. Uses the UTC epoch for a standard expire time.
Add IE support for cookie deletion. Style and test fixes.
72e4a6c
Add IE support for cookie deletion. Documentation updates.
aecee67
Add IE support for cookie deletion. Python 3.4 related test fixes.
da16fd9
@coveralls
Copy link

coveralls commented Jul 23, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 97.867% when pulling da16fd9 on aleksey-kutepov:patch-1 into 328bb36 on KeepSafe:master.

@coveralls
Copy link

coveralls commented Jul 23, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 97.876% when pulling da16fd9 on aleksey-kutepov:patch-1 into 328bb36 on KeepSafe:master.

@coveralls
Copy link

coveralls commented Jul 23, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 97.876% when pulling da16fd9 on aleksey-kutepov:patch-1 into 328bb36 on KeepSafe:master.

@coveralls
Copy link

coveralls commented Jul 23, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 97.984% when pulling 46adb6f on aleksey-kutepov:patch-1 into 328bb36 on KeepSafe:master.

@asvetlov asvetlov merged commit 2bcdd5c into aio-libs:master Jul 23, 2016
@asvetlov asvetlov mentioned this pull request Jul 23, 2016
Closed
3 tasks
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aleksey-kutepov @coveralls @asvetlov @SethMichaelLarson