Move metadata to pyproject.toml #9951

cdce8p · 2024-11-17T22:59:33Z

What do these changes do?

The metadata changes:

 Metadata-Version: 2.1
 Name: aiohttp
 Version: 4.0.0a2.dev0
 Summary: Async http client/server framework (asyncio)
-Maintainer: aiohttp team <team@aiohttp.org>
-Maintainer-email: team@aiohttp.org
+Maintainer-email: aiohttp team <team@aiohttp.org>
 License: Apache-2.0
-Home-page: https://github.com/aio-libs/aiohttp
+Project-URL: Homepage, https://github.com/aio-libs/aiohttp
 Project-URL: Chat: Matrix, https://matrix.to/#/#aio-libs:matrix.org
 Project-URL: Chat: Matrix Space, https://matrix.to/#/#aio-libs-space:matrix.org
 Project-URL: CI: GitHub Actions, https://github.com/aio-libs/aiohttp/actions?query=workflow%3ACI
 Project-URL: Coverage: codecov, https://codecov.io/github/aio-libs/aiohttp
 Project-URL: Docs: Changelog, https://docs.aiohttp.org/en/stable/changes.html
 Project-URL: Docs: RTD, https://docs.aiohttp.org
 Project-URL: GitHub: issues, https://github.com/aio-libs/aiohttp/issues
 Project-URL: GitHub: repo, https://github.com/aio-libs/aiohttp
 Classifier: Development Status :: 5 - Production/Stable
 Classifier: Framework :: AsyncIO
 Classifier: Intended Audience :: Developers
 Classifier: License :: OSI Approved :: Apache Software License
 Classifier: Operating System :: POSIX
 Classifier: Operating System :: MacOS :: MacOS X
 Classifier: Operating System :: Microsoft :: Windows
 Classifier: Programming Language :: Python
 Classifier: Programming Language :: Python :: 3
 Classifier: Programming Language :: Python :: 3.9
 Classifier: Programming Language :: Python :: 3.10
 Classifier: Programming Language :: Python :: 3.11
 Classifier: Programming Language :: Python :: 3.12
 Classifier: Programming Language :: Python :: 3.13
 Classifier: Topic :: Internet :: WWW/HTTP
 Requires-Python: >=3.9
 Description-Content-Type: text/x-rst
 License-File: LICENSE.txt
 Requires-Dist: aiohappyeyeballs >=2.3.0
 Requires-Dist: aiosignal >=1.1.2
 Requires-Dist: frozenlist >=1.1.1
 Requires-Dist: multidict <7.0,>=4.5
 Requires-Dist: propcache >=0.2.0
 Requires-Dist: yarl <2.0,>=1.17.0
 Requires-Dist: async-timeout <6.0,>=4.0 ; python_version < "3.11"
 Provides-Extra: speedups
 Requires-Dist: brotlicffi ; (platform_python_implementation != "CPython") and extra == 'speedups'
 Requires-Dist: Brotli ; (platform_python_implementation == "CPython") and extra == 'speedups'
 Requires-Dist: aiodns >=3.2.0 ; (sys_platform == "linux" or sys_platform == "darwin") and extra == 'speedups'

 ...

Open questions

Should this PR be backported? It's possible, might just require some manual work due to merge conflicts.

codecov · 2024-11-17T23:05:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (4c3b1c6) to head (51bb1d2).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #9951   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         121      121           
  Lines       36728    36728           
  Branches     4384     4384           
=======================================
  Hits        36262    36262           
  Misses        314      314           
  Partials      152      152

Flag	Coverage Δ
CI-GHA	`98.61% <ø> (ø)`
OS-Linux	`98.30% <ø> (ø)`
OS-Windows	`96.13% <ø> (ø)`
OS-macOS	`97.39% <ø> (-0.01%)`	⬇️
Py-3.10.11	`97.24% <ø> (-0.01%)`	⬇️
Py-3.10.15	`97.84% <ø> (+0.05%)`	⬆️
Py-3.11.10	`97.84% <ø> (ø)`
Py-3.11.9	`97.29% <ø> (ø)`
Py-3.12.7	`98.37% <ø> (ø)`
Py-3.13.0	`98.35% <ø> (+0.04%)`	⬆️
Py-3.9.13	`97.17% <ø> (+<0.01%)`	⬆️
Py-3.9.20	`97.71% <ø> (-0.05%)`	⬇️
Py-pypy7.3.16	`97.32% <ø> (ø)`
VM-macos	`97.39% <ø> (-0.01%)`	⬇️
VM-ubuntu	`98.30% <ø> (ø)`
VM-windows	`96.13% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

codspeed-hq · 2024-11-17T23:05:51Z

CodSpeed Performance Report

Merging #9951 will not alter performance

_{Comparing cdce8p:move-metadata (51bb1d2) with master (4c3b1c6)}

Summary

✅ 43 untouched benchmarks

webknjaz · 2024-11-17T23:20:59Z

Let's not rush this. Keeping a dedicated config is a conscious choice. Also, PRs must not reformat half a project along with changing the packaging configs.

FWIW I'd rather keep it as is for now. Especially, since I was going to sync the configs across the projects and this is going to cause a lot of headache since it conflicts with how things are now.

I'm 👎 on this migration right now. It'd be interesting to gather the current dependency limitations in the downstreams to make an informed choice. Additionally, the move would have to happen in the dependencies first.

cdce8p · 2024-11-17T23:30:42Z

Let's not rush this. Keeping a dedicated config is a conscious choice. Also, PRs must not reformat half a project along with changing the packaging configs.

That's actually a bug with the current black config. Since it can't detect the lowest supported version, it assumes py33 and doesn't use the correct style. In f718fa1 I've pinned the lowest version which doesn't cause any reformatting.

FWIW I'd rather keep it as is for now. Especially, since I was going to sync the configs across the projects and this is going to cause a lot of headache since it conflicts with how things are now.

I'm 👎 on this migration right now. It'd be interesting to gather the current dependency limitations in the downstreams to make an informed choice. Additionally, the move would have to happen in the dependencies first.

I'm probably missing something here. This PR doesn't affect any downstream projects. The project metadata change is minimal and spec compliant.

Tbh I just thought it might be a good time to move the static metadata after I learned that it can work fine with setup.py. It will probably still take a while (couple of years) but I expect setuptools to eventually deprecate the setup.cfg config.

There is no strict need to do that now, so if you're opposed feel free to close the PR.

asvetlov

I personally don't care where the project metadata sits until it works and I personally shouldn't spend additional time on the infrastructure maintenance.

asvetlov · 2024-11-18T21:13:24Z

That's actually a bug with the current black config.

@cdce8p could you please extract a fix for this particular problem into a separate PR? A small patch has a great chance to be reviewed and approved quickly.

asvetlov · 2024-11-18T21:14:48Z

Ooh, sorry. I've pushed the wrong button and closed the PR. Please accept my apologizes.

cdce8p · 2024-11-18T21:25:42Z

That's actually a bug with the current black config.

@cdce8p could you please extract a fix for this particular problem into a separate PR? A small patch has a great chance to be reviewed and approved quickly.

@asvetlov See #9962. It looks bigger than it actually is.

asvetlov · 2024-11-19T10:30:20Z

Thanks, @cdce8p
The PR is merged and back ported

cdce8p requested review from webknjaz and asvetlov as code owners November 17, 2024 22:59

psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 17, 2024

cdce8p requested a review from bdraco November 17, 2024 22:59

cdce8p force-pushed the move-metadata branch from bba81fd to f718fa1 Compare November 17, 2024 23:19

cdce8p force-pushed the move-metadata branch from 0d487cf to 92f533f Compare November 17, 2024 23:33

asvetlov reviewed Nov 18, 2024

View reviewed changes

asvetlov closed this Nov 18, 2024

asvetlov reopened this Nov 18, 2024

cdce8p added 2 commits November 19, 2024 08:49

Move metadata to pyproject.toml

8f80fdc

Fix sync-direct-runtime-deps script

51bb1d2

cdce8p force-pushed the move-metadata branch from 92f533f to 51bb1d2 Compare November 19, 2024 07:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move metadata to pyproject.toml #9951

Move metadata to pyproject.toml #9951

cdce8p commented Nov 17, 2024

codecov bot commented Nov 17, 2024 •

edited

Loading

codspeed-hq bot commented Nov 17, 2024 •

edited

Loading

webknjaz commented Nov 17, 2024

cdce8p commented Nov 17, 2024 •

edited

Loading

asvetlov left a comment

asvetlov commented Nov 18, 2024

asvetlov commented Nov 18, 2024

cdce8p commented Nov 18, 2024 •

edited

Loading

asvetlov commented Nov 19, 2024

Move metadata to pyproject.toml #9951

Are you sure you want to change the base?

Move metadata to pyproject.toml #9951

Conversation

cdce8p commented Nov 17, 2024

What do these changes do?

codecov bot commented Nov 17, 2024 • edited Loading

Codecov Report

codspeed-hq bot commented Nov 17, 2024 • edited Loading

CodSpeed Performance Report

Merging #9951 will not alter performance

Summary

webknjaz commented Nov 17, 2024

cdce8p commented Nov 17, 2024 • edited Loading

asvetlov left a comment

Choose a reason for hiding this comment

asvetlov commented Nov 18, 2024

asvetlov commented Nov 18, 2024

cdce8p commented Nov 18, 2024 • edited Loading

asvetlov commented Nov 19, 2024

codecov bot commented Nov 17, 2024 •

edited

Loading

codspeed-hq bot commented Nov 17, 2024 •

edited

Loading

cdce8p commented Nov 17, 2024 •

edited

Loading

cdce8p commented Nov 18, 2024 •

edited

Loading