Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore only construct the allowed_methods set once for a StaticResource #9976

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 19, 2024

Was reverted in #9972 because it introduced a regression with adding and OPTIONS method. Fix the set_options_route call instead and restore the change. There is now test coverage for this case as well via #9975

…urce`

Was reverted in #9972 because it introduced a regression with adding
and OPTIONS method. Fix the ``set_options_route`` call instead and
restore the change. There is now test coverage for this case as well
via #9975
@bdraco bdraco added backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Nov 19, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 19, 2024
Copy link

codspeed-hq bot commented Nov 19, 2024

CodSpeed Performance Report

Merging #9976 will not alter performance

Comparing fix_set_once (305292e) with master (8704bc7)

Summary

✅ 43 untouched benchmarks

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (8704bc7) to head (305292e).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9976      +/-   ##
==========================================
+ Coverage   98.71%   98.73%   +0.01%     
==========================================
  Files         121      121              
  Lines       36727    36730       +3     
  Branches     4383     4383              
==========================================
+ Hits        36254    36264      +10     
+ Misses        318      314       -4     
+ Partials      155      152       -3     
Flag Coverage Δ
CI-GHA 98.62% <100.00%> (+0.01%) ⬆️
OS-Linux 98.31% <100.00%> (+0.01%) ⬆️
OS-Windows 96.13% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.40% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.25% <100.00%> (-0.01%) ⬇️
Py-3.10.15 97.85% <100.00%> (+0.05%) ⬆️
Py-3.11.10 97.84% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.29% <100.00%> (-0.01%) ⬇️
Py-3.12.7 98.37% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 98.31% <100.00%> (-0.05%) ⬇️
Py-3.9.13 97.17% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.72% <100.00%> (-0.05%) ⬇️
Py-pypy7.3.16 97.32% <100.00%> (?)
VM-macos 97.40% <100.00%> (-0.01%) ⬇️
VM-ubuntu 98.31% <100.00%> (+0.01%) ⬆️
VM-windows 96.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review November 19, 2024 05:29
@bdraco bdraco enabled auto-merge (squash) November 19, 2024 05:31
@bdraco bdraco merged commit 2b40f6b into master Nov 19, 2024
39 of 40 checks passed
@bdraco bdraco deleted the fix_set_once branch November 19, 2024 05:34
Copy link
Contributor

patchback bot commented Nov 19, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/2b40f6b79fae3bc84ff90f7dee6b8e780716d179/pr-9976

Backported as #9979

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Nov 19, 2024

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/2b40f6b79fae3bc84ff90f7dee6b8e780716d179/pr-9976

Backported as #9980

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 19, 2024
bdraco added a commit that referenced this pull request Nov 19, 2024
…_methods set once for a `StaticResource` (#9979)

Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco added a commit that referenced this pull request Nov 19, 2024
…_methods set once for a `StaticResource` (#9980)

Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant