-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore only construct the allowed_methods set once for a StaticResource
#9976
Conversation
CodSpeed Performance ReportMerging #9976 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9976 +/- ##
==========================================
+ Coverage 98.71% 98.73% +0.01%
==========================================
Files 121 121
Lines 36727 36730 +3
Branches 4383 4383
==========================================
+ Hits 36254 36264 +10
+ Misses 318 314 -4
+ Partials 155 152 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9979 🤖 @patchback |
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #9980 🤖 @patchback |
…_methods set once for a `StaticResource` (#9979) Co-authored-by: J. Nick Koston <nick@koston.org>
…_methods set once for a `StaticResource` (#9980) Co-authored-by: J. Nick Koston <nick@koston.org>
Was reverted in #9972 because it introduced a regression with adding and OPTIONS method. Fix the
set_options_route
call instead and restore the change. There is now test coverage for this case as well via #9975