Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote username in SCRAM auth #1043

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Quote username in SCRAM auth #1043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion aiokafka/conn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,7 +719,13 @@
self._authenticator = self.authenticator_scram()

def first_message(self):
client_first_bare = f"n={self._sasl_plain_username},r={self._nonce}"
# The characters ',' or '=' in usernames are sent as '=2C' and
# '=3D' respectively.
# https://datatracker.ietf.org/doc/html/rfc5802#section-5.1
quoted_username = (

Check warning on line 725 in aiokafka/conn.py

View check run for this annotation

Codecov / codecov/patch

aiokafka/conn.py#L725 

Added line #L725 was not covered by tests
self._sasl_plain_username.replace("=", "=3D").replace( ",", "=2C")
) # fmt: skip
client_first_bare = f"n={quoted_username},r={self._nonce}"

Check warning on line 728 in aiokafka/conn.py

View check run for this annotation

Codecov / codecov/patch

aiokafka/conn.py#L728 

Added line #L728 was not covered by tests
self._auth_message += client_first_bare
return "n,," + client_first_bare

Expand Down
Loading