Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SPDX license identifier #1076

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use SPDX license identifier #1076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ name = "aiokafka"
description = "Kafka integration with asyncio"
readme = "README.rst"
requires-python = ">=3.9"
license = { file = "LICENSE" }
license = { text = "Apache-2.0" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to PEP, this ways is deprecated:

Table values for the license key in the [project] table, including the text and file table subkeys, are now deprecated.

Suggested change
license = { text = "Apache-2.0" }
license = "Apache-2.0"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Unfortunately setuptools doesn't support the new syntax yet. Using license.text until then will make updating later a bit easier and also help with readability on PyPI.

before

Screenshot 2024-11-19 at 08 37 26

after

Screenshot 2024-11-19 at 08 38 02

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably it's time to switch to hatch (need to figure out how to deal with cython to do this). If not, I'd rather wait until setuptools is fixed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not, I'd rather wait until setuptools is fixed.

This will take some time, probably months. It's currently blocked by other issues which need to be worked out first. pypa/setuptools#4629

I've opened the PR here now, as using the SPDX expression even for the "legacy" License field can help tools which parse the project metadata to look licenses.

authors = [
{ name = "Andrew Svetlov", email = "andrew.svetlov@gmail.com" },
]
Expand Down
Loading