Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for sasl ssl #663

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LizardWizzard
Copy link

Changes

Hello! Thank you for great library! Just wanted to test if sasl_ssl auth method is working correctly while setting it up for my project. Realised that this scenario is missing in library's functional tests. So I've added it.

By the way, when tried to run tests on master there was a bunch of warnings like RuntimeWarning: coroutine 'TestKafkaClientIntegration.test_failed_bootstrap' was never awaited so many tests didnt actually run. When tried on top of the latest release tests run smoothly

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .misc: A ticket has been closed, but it is not of interest to users.

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2020

CLA assistant check
All committers have signed the CLA.

@tvoinarovskyi
Copy link
Member

Thanks for the contribution! I remember having issues with the SSL+SASL scenario, because we create certificates for SSL in a very simple manner, not sure what was the specific problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants