Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Hello! Thank you for great library! Just wanted to test if sasl_ssl auth method is working correctly while setting it up for my project. Realised that this scenario is missing in library's functional tests. So I've added it.
By the way, when tried to run tests on master there was a bunch of warnings like
RuntimeWarning: coroutine 'TestKafkaClientIntegration.test_failed_bootstrap' was never awaited
so many tests didnt actually run. When tried on top of the latest release tests run smoothlyChecklist
CHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.misc
: A ticket has been closed, but it is not of interest to users.