-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Codec for ZStandard Compression #801
Conversation
Codecov Report
@@ Coverage Diff @@
## master #801 +/- ##
==========================================
- Coverage 97.92% 97.89% -0.04%
==========================================
Files 31 31
Lines 5309 5358 +49
==========================================
+ Hits 5199 5245 +46
- Misses 110 113 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Can we please get a release out with this change? Thanks! |
Sure, we're working on it |
We are currently running into a scenario where AIOKafka fails to consume messages when ZSTD is set as broker-level compression, instead of at consumer-level. Is there any plans to address this, @ods ? Thanks! |
@DeLaboreMercurio The new release is on the way. |
getting below error when trying to consume from a ZSTD compressed record from kafka. raise UnsupportedCodecError( error log: Traceback (most recent call last): Process finished with exit code 1 My Code for consuming a kafka topic: from kafka import KafkaConsumer except KeyboardInterrupt: |
Changes
KIP-110
Checklist
CHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.