Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace python-snappy and zstandard with cramjam #940

Merged
merged 5 commits into from
Nov 19, 2023
Merged

Conversation

ods
Copy link
Collaborator

@ods ods commented Nov 15, 2023

Changes

Fixes compatibility issue with Python 3.12 (see #931)

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (88c6945) 84.21% compared to head (b3d8a3c) 84.25%.

Files Patch % Lines
aiokafka/codec.py 85.00% 3 Missing ⚠️
aiokafka/record/legacy_records.py 0.00% 2 Missing ⚠️
aiokafka/protocol/message.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #940      +/-   ##
==========================================
+ Coverage   84.21%   84.25%   +0.03%     
==========================================
  Files          87       87              
  Lines       10085    10039      -46     
==========================================
- Hits         8493     8458      -35     
+ Misses       1592     1581      -11     
Flag Coverage Δ
cext 79.29% <75.00%> (+0.04%) ⬆️
integration 84.23% <75.00%> (+0.03%) ⬆️
purepy 84.00% <75.00%> (+0.03%) ⬆️
unit 51.45% <75.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ods ods merged commit 5266f46 into aio-libs:master Nov 19, 2023
26 of 28 checks passed
@backbord
Copy link

backbord commented Apr 8, 2024

Hi,

I just noticed and wanted to let you know that the aiokafka.codec.ZSTD_MAX_OUTPUT_SIZE constant seems to be an unused left-over from https://github.com/aio-libs/aiokafka/pull/940/files#diff-54e25ccbf1e01e453e8710de8482f86dc72917d1eec778100b73a4e5c52b5a3aR240

Best!

@ods
Copy link
Collaborator Author

ods commented Apr 9, 2024

Thanks, @backbord! I'll remove it eventually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants