Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup after kafka-python merge #947

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Conversation

ods
Copy link
Collaborator

@ods ods commented Nov 29, 2023

Changes

Follow-up to merge of python-kafka, removes dead code.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8814e7b) 84.25% compared to head (fdba764) 94.88%.

Files Patch % Lines
aiokafka/protocol/message.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #947       +/-   ##
===========================================
+ Coverage   84.25%   94.88%   +10.63%     
===========================================
  Files          87      106       +19     
  Lines       10040    16136     +6096     
  Branches        0     2592     +2592     
===========================================
+ Hits         8459    15311     +6852     
+ Misses       1581      551     -1030     
- Partials        0      274      +274     
Flag Coverage Δ
cext 91.57% <0.00%> (+12.26%) ⬆️
integration 94.55% <0.00%> (+10.32%) ⬆️
purepy 94.41% <0.00%> (+10.41%) ⬆️
unit 45.19% <0.00%> (-6.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ods ods changed the title Kafka python cleanup Cleanup after kafka-python merge Nov 29, 2023
@ods ods merged commit a25e5c2 into aio-libs:master Nov 29, 2023
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant