Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: close some debts after kafka-python merge #962

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

ods
Copy link
Collaborator

@ods ods commented Jan 18, 2024

Changes

  • Drop isinstance hack (not needed anymore)
  • Add 2.6 case to check_version

@ods ods changed the title Chore: clase some debts after kafka-python merge Chore: close some debts after kafka-python merge Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72c1969) 95.07% compared to head (de6942b) 95.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #962   +/-   ##
=======================================
  Coverage   95.07%   95.08%           
=======================================
  Files         106      106           
  Lines       16323    16323           
  Branches     2610     2610           
=======================================
+ Hits        15519    15520    +1     
  Misses        530      530           
+ Partials      274      273    -1     
Flag Coverage Δ
cext 91.76% <100.00%> (-0.01%) ⬇️
integration 94.72% <100.00%> (+<0.01%) ⬆️
purepy 94.57% <100.00%> (+0.02%) ⬆️
unit 44.85% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ods ods merged commit 2cbeee6 into aio-libs:master Jan 18, 2024
31 of 33 checks passed
@ods ods deleted the chore-debts branch January 18, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant