Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added get_dialect func to have ability to pass json_serializer #451

Merged
merged 1 commit into from
May 9, 2018

Conversation

Gr1N
Copy link
Contributor

@Gr1N Gr1N commented Mar 13, 2018

Hi,

I would like to introduce simple change. In my cases I want to use another JSON serializer, for now I need to copy whole dialect initialization code into my sources. I don't want to do this. So in PR you can find new function called get_dialect. Changes backward compatible, but I'm open to make any changes and improvements.

Best regards

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@codecov
Copy link

codecov bot commented Mar 13, 2018

Codecov Report

Merging #451 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
+ Coverage   93.57%   93.57%   +<.01%     
==========================================
  Files          25       25              
  Lines        3672     3675       +3     
  Branches      194      194              
==========================================
+ Hits         3436     3439       +3     
  Misses        198      198              
  Partials       38       38
Impacted Files Coverage Δ
aiopg/sa/engine.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9996089...9f23fc9. Read the comment docs.

@vir-mir vir-mir merged commit 45babe7 into aio-libs:master May 9, 2018
@Gr1N
Copy link
Contributor Author

Gr1N commented May 9, 2018

@vir-mir could you please release new version of package?

@vir-mir
Copy link
Member

vir-mir commented May 10, 2018

@Gr1N no, I do not release releases

@asvetlov when the new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants