-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix on_connect multiple call on acquire #552
Conversation
Codecov Report
@@ Coverage Diff @@
## master #552 +/- ##
==========================================
+ Coverage 94.35% 94.36% +<.01%
==========================================
Files 27 27
Lines 3740 3744 +4
Branches 171 172 +1
==========================================
+ Hits 3529 3533 +4
Misses 179 179
Partials 32 32
Continue to review full report at Codecov.
|
+1 on this, can we get it merged? |
Can you please merge this patch? PR is small and has test 👍 cc @asvetlov @popravich @vir-mir (based on MAINTAINERS.txt) |
|
Is this fix actually going to be considered for merge if I go through the CLA process? |
Hi @aaliddell, Thanks for the contribution. |
Fixes #551
The Pool
on_connect
handler is now called exactly once per connection, rather than on every call toacquire
Also, some things on your PR template checklist can't be done, as you don't have a CONTRIBUTORS.txt or a CHANGES folder?
Checklist
If you provide code modification, please add yourself toCONTRIBUTORS.txt
Add a new news fragment into theCHANGES
folder