Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on_connect multiple call on acquire #552

Merged
merged 4 commits into from
Dec 5, 2020
Merged

Fix on_connect multiple call on acquire #552

merged 4 commits into from
Dec 5, 2020

Conversation

aaliddell
Copy link
Contributor

@aaliddell aaliddell commented Apr 1, 2019

Fixes #551

The Pool on_connect handler is now called exactly once per connection, rather than on every call to acquire

Also, some things on your PR template checklist can't be done, as you don't have a CONTRIBUTORS.txt or a CHANGES folder?

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • Add a new news fragment into the CHANGES folder

@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #552 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
+ Coverage   94.35%   94.36%   +<.01%     
==========================================
  Files          27       27              
  Lines        3740     3744       +4     
  Branches      171      172       +1     
==========================================
+ Hits         3529     3533       +4     
  Misses        179      179              
  Partials       32       32
Impacted Files Coverage Δ
tests/test_pool.py 99.75% <100%> (ø) ⬆️
aiopg/pool.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fdf7b9...a849072. Read the comment docs.

@brianmaissy
Copy link
Contributor

+1 on this, can we get it merged?

@oleksandr-kuzmenko
Copy link

Can you please merge this patch? PR is small and has test 👍

cc @asvetlov @popravich @vir-mir (based on MAINTAINERS.txt)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@aaliddell
Copy link
Contributor Author

Is this fix actually going to be considered for merge if I go through the CLA process?

@Pliner
Copy link
Member

Pliner commented Dec 5, 2020

Hi @aaliddell,

Thanks for the contribution.

@Pliner Pliner merged commit 7f8a846 into aio-libs:master Dec 5, 2020
@Pliner Pliner mentioned this pull request Dec 5, 2020
@aaliddell aaliddell deleted the on_connect branch February 16, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pool on_connect callback called on every acquire
5 participants