-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove blocking connection.cancel() method #570
Conversation
This pull request fixes 1 alert when merging 1d0cdde into 9fdf7b9 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging b7fe8e6 into 9fdf7b9 - view on LGTM.com fixed alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #570 +/- ##
==========================================
- Coverage 94.35% 94.05% -0.31%
==========================================
Files 27 27
Lines 3740 3700 -40
Branches 171 169 -2
==========================================
- Hits 3529 3480 -49
- Misses 179 189 +10
+ Partials 32 31 -1
Continue to review full report at Codecov.
|
b7fe8e6
to
953e6e7
Compare
This pull request fixes 1 alert when merging 953e6e7 into 9fdf7b9 - view on LGTM.com fixed alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #570 +/- ##
==========================================
+ Coverage 92.89% 93.07% +0.18%
==========================================
Files 13 13
Lines 1562 1531 -31
Branches 179 172 -7
==========================================
- Hits 1451 1425 -26
+ Misses 79 78 -1
+ Partials 32 28 -4
Continue to review full report at Codecov.
|
This pull request fixes 1 alert when merging 08c618b into 9fdf7b9 - view on LGTM.com fixed alerts:
|
This comment has been minimized.
This comment has been minimized.
Is this going to actually be merged if I go through the CLA process? |
Hi @brianmaissy, First of all, thanks for your contribution and sorry for the huge delay in the reply. Do you have time to rebase this PR? It would be nice to include it to the next minor version. |
08c618b
to
a485878
Compare
@brianmaissy Thanks for rebasing, I've missed it. |
@asvetlov Are you ok with this PR? I'm going to merge and release it as 1.2beta if so. |
Well, let's merge it and test. @asvetlov any later suggestions are welcome @brianmaissy Will you be able to test it on your workload? |
Yes. Are you going to release a beta build? |
|
seems to be working fine 👍 |
Thanks 🔥 I'm going to test it during the next week as well. |
@Pliner I think I found what may be a problem: if a |
@brianmaissy I have the same trouble 👍
Yes, please 😊 |
This can be caused when a query times out while running, for example, and the connection is closed as a result (as opposed to cancelling the query, since PR aio-libs#570). In this case, we would rather not emit the ROLLBACK (the connection is already closed, so the transaction is over anyway), rather than raising an exception when trying to use a connection which is already closed. See issue aio-libs#777.
This can be caused when a query times out while running, for example, and the connection is closed as a result (as opposed to cancelling the query, since PR aio-libs#570). In this case, we would rather not emit the ROLLBACK (the connection is already closed, so the transaction is over anyway), rather than raising an exception when trying to use a connection which is already closed. See issue aio-libs#777.
This can be caused when a query times out while running, for example, and the connection is closed as a result (as opposed to cancelling the query, since PR aio-libs#570). In this case, we would rather not emit the ROLLBACK (the connection is already closed, so the transaction is over anyway), rather than raising an exception when trying to use a connection which is already closed. See issue aio-libs#777.
* Don't run ROLLBACK when the connection is closed. This can be caused when a query times out while running, for example, and the connection is closed as a result (as opposed to cancelling the query, since PR #570). In this case, we would rather not emit the ROLLBACK (the connection is already closed, so the transaction is over anyway), rather than raising an exception when trying to use a connection which is already closed. See issue #777. * add tests for cancelled queries in transaction * Update test_transaction.py * Update test_sa_transaction.py * Update connection.py Co-authored-by: Yury Pliner <yury.pliner@gmail.com>
Closes #491
Closes #375