Handle lost connections and EOF during readlines #73
Conversation
Also, add some much improved debugging options for when the test suite is run with the -E option. Update the documentation.
Lift some additional (non-line-length) tests from #59.
|
I grabbed the few additional non-line-length related tests from #59 although I'm not sure they don't cover cases already covered elsewhere. I just wanted to prove to myself that this PR handles those cases too. I feel pretty good about this one, even if we're not technically handling EOF correctly. It does require checking for |
aiosmtpd/tests/test_smtp.py
Outdated
| client.docmd('DATA') | ||
| # Start sending the DATA but send an EOF before that completes, | ||
| # i.e. before the .\r\n | ||
| client.send(b'From: <anne@example.com>\0x4') |
There was a problem hiding this comment.
This should probably be \x04.
| client.helo('example.com') | ||
| # Start sending a command but reset the connection before that | ||
| # completes, i.e. before the \r\n | ||
| client.send('MAIL FROM: <anne') |
There was a problem hiding this comment.
I think this should be a bytestring for consistency with the other tests. (Does SMTP.send even accept a str?)
|
Does sending |
|
@Mortal I think you're right that the |
|
Oh, also, yes |
Test cases for connection problems during readline()
Also, add some much improved debugging options for when the test suite is run
with the -E option.
Update the documentation.
Closes #61