-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Appveyor config for testing on Windows #81
Conversation
On Appveyor, tox outputs "SKIPPED: qa: InterpreterNotFound: python3"
You will want to go to https://ci.appveyor.com/notifications and disable email notifications after signing up for Appveyor. |
I've enabled AppVeyor for aiosmtpd. I guess you're saying I want to disable email notifications because they'll be so spammy? |
As for your first comment about (I wonder if we need to start moving all those |
Yeah, I personally think it's too much with an email per failed build. The I think the |
On May 07, 2017, at 01:00 PM, Mathias Rav wrote:
The `eof_received()` coverage problem still persists. It seems like a bad
band-aid to me -- I couldn't exactly figure out under which circumstances
self.transport would become None, so I would say it needs an explanation in
the code at the very least.
I'm seeing that with my minor formatting branch. I'm going to investigate why
that conditional is needed on Linux, which I hope will allow me to eliminate
it or at least be able to describe the problem and find a way to cover it
under Windows.
I think the `*-coverage.ini` should be moved out of the top-level. I tried to
figure out if I could avoid having six distinct files, but I don't know
enough about `coverage` to say if that is possible.
Unfortunately I don't think there is, but I've been meaning to engage with
upstream coverage team to see if there's a better solution (maybe even help
hack one up - e.g. something similar to tox's generated environments).
|
My suspicion is that the traceback on Oh, and here's where I make a plea to upstream coverage to handle the multiple coverage.ini files better. |
This PR adds an Appveyor config. When aio-libs/aiosmtpd is created on https://ci.appveyor.com (by the FLUFL), the config will be automatically picked up and tests will start running whenever master is updated.
Currently coverage fails because this if-branch is always taken in tests:
I can't figure out how to make a test where
eof_received()
is called whenself.transport
is None, but it seems that this is exercised when testing on Linux by the tests in TestStartTLS (discovered by addingraise Exception()
at the end of eof_received()).