Ensure support for Python 3.12 and PyPy 3.8-3.10 #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamim
changed the title
|
Hello @mjpieters, Thank you for developing this library! 🙇🏻♂️ Can you please take a look at this PR? The changes are trivial, so it shouldn't take too long. Thanks in advance! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #553 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 2 2
Lines 254 254
Branches 23 23
=======================================
Hits 253 253
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jamim
force-pushed
the
feature/python-3.12
branch
from
4841a00 to
d50234a
Compare
Jamim
force-pushed
the
feature/python-3.12
branch
2 times, most recently
from
f8b9812 to
de4435b
Compare
|
Hello @webknjaz, Sorry for bothering you, but would you mind looking into this PR once you have some spare time? Thanks! |
These changes: * enable testing for Python 3.12 and PyPy 3.8-3.10 * update classifiers at setup.cfg * add a news fragment
Jamim
force-pushed
the
feature/python-3.12
branch
from
de4435b to
46080b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I believe it would be nice to have explicit support for Python 3.12.
So I'd like to propose this PR.
What do these changes do?
classifiersatsetup.cfgAre there changes in behavior for the user?
No.
Related issue number
I suppose #541 might be resolved by releasing a new version once this PR is merged.
Since
cibuildwheelwas already updated to2.16.2, it will buildwheelsfor Python 3.12 as well as for prior versions.Checklist
CHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.