Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust env markers and deps for Python 3.8+ #1005

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Adjust env markers and deps for Python 3.8+ #1005

merged 2 commits into from
Sep 9, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 9, 2024 •
edited
Loading

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Sep 9, 2024
bdraco referenced this pull request Sep 9, 2024
@bdraco
Drop python 3.7 from the CI
4fffc3d 
The builds no longer work for 3.7
@bdraco @webknjaz
Update .pre-commit-config.yaml
52ff40e 
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <webknjaz@redhat.com>
@bdraco bdraco marked this pull request as ready for review September 9, 2024 23:57
@bdraco bdraco merged commit 3695ce6 into master Sep 9, 2024
44 of 48 checks passed
@bdraco bdraco deleted the drop_env_marker branch September 9, 2024 23:57
@webknjaz
Copy link
Member

@bdraco missed removing the conditional imports: https://app.codecov.io/github/aio-libs/multidict/commit/6197e510d9c11814524f1a48117cf2a45ba1a59a/blob/tests/conftest.py?flags%5B0%5D=pytest#L11.

@bdraco
Copy link
Member Author

bdraco commented Sep 10, 2024

I checked the main code base but missed the tests! I’ll take a look when I get back back from finding dinner before I go to bed

@bdraco bdraco mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdraco @webknjaz