Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump RTD to use Python 3.12 and ubuntu-24.04 #1007

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Bump RTD to use Python 3.12 and ubuntu-24.04 #1007

merged 2 commits into from
Sep 9, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 9, 2024

Bumping sphinx is currently blocked because 8.x required Python 3.10+

.github/workflows/ci-cd.yml Outdated Show resolved Hide resolved
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Sep 9, 2024
@bdraco bdraco marked this pull request as ready for review September 9, 2024 23:50
@bdraco bdraco enabled auto-merge (squash) September 9, 2024 23:51
@bdraco bdraco merged commit 82cab20 into master Sep 9, 2024
44 of 48 checks passed
@bdraco bdraco deleted the rtd_bump branch September 9, 2024 23:51
tools:
python: >-
3.9
3.12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N.B. In the past, I'd keep this at the lowest possible value to accommodate docs contributors running this on various versions. However, nowadays, I sometimes make it have the version that matches GHA.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdraco this is something I'd like to have in the future: https://github.com/ansible/awx-plugins/blob/8ba56cc/.readthedocs.yaml — the same entry-points/automations being called @ RTD and GHA. That project doesn't use make, but I wanted to show the general idea.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does looks like a nicer / more maintainable design. I'm still wrapping my head around all the GHAs between all the projects. Its a lot to take in, and I'm playing catch up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants