Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade actions/[upload|download]-artifact and other GHA dependencies #1016

Merged
merged 6 commits into from
Sep 22, 2024

Conversation

lysnikolaou
Copy link
Contributor

What do these changes do?

  • Upgrade actions/upload-artifact to v4 since v2 is deprecated and v3 is scheduled to be deprecated in November.

Are there changes in behavior for the user?

No.

@lysnikolaou lysnikolaou changed the title Upgrade actions/upload-artifact to v4 Upgrade actions/[upload|download]-artifact to v4 Sep 18, 2024
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, look into the yarl PRs where I did this properly (and the follow-ups!). This needs unique names for the artifacts.

.github/workflows/reusable-build-wheel.yml Outdated Show resolved Hide resolved
.github/workflows/ci-cd.yml Outdated Show resolved Hide resolved
@lysnikolaou lysnikolaou changed the title Upgrade actions/[upload|download]-artifact to v4 Upgrade actions/[upload|download]-artifact and other GHA dependencies Sep 19, 2024
@lysnikolaou
Copy link
Contributor Author

@webknjaz Thanks a lot for the review and the help! I think we're good to go on this now.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any immediate problems, reviewing from phone. But I'd rather double-check from the laptop later..

.github/workflows/ci-cd.yml Outdated Show resolved Hide resolved
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Sep 22, 2024
@bdraco
Copy link
Member

bdraco commented Sep 22, 2024

Thanks @lysnikolaou

@bdraco bdraco merged commit e07ae9d into aio-libs:master Sep 22, 2024
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants