-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade actions/[upload|download]-artifact and other GHA dependencies #1016
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, look into the yarl PRs where I did this properly (and the follow-ups!). This needs unique names for the artifacts.
4ce813d
to
fd29eb3
Compare
@webknjaz Thanks a lot for the review and the help! I think we're good to go on this now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any immediate problems, reviewing from phone. But I'd rather double-check from the laptop later..
Thanks @lysnikolaou |
What do these changes do?
actions/upload-artifact
to v4 since v2 is deprecated and v3 is scheduled to be deprecated in November.Are there changes in behavior for the user?
No.