Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LICENSE to include full text of Apache license #1017

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Manishearth
Copy link

It's common to have the full license in the repo so that various tooling can correctly recognize it.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never change somebody else's copyright lines. Especially, not to pretend that the content got created this year. It's not how it works. This could probably go to the notice file, I suppose. But it might be good to have a discussion first.

@Manishearth
Copy link
Author

I mean, this isn't me changing it, this is me proposing a change, you are welcome to reject it but I don't think I'm in the wrong for proposing it and it feels rather weird to get such a response to a PR.

I reset the year to 2016, apologies for not mentioning that in the PR body. I've noticed most open source projects like to keep the year up to date and haven't found any that dislike that, so I felt I could just do that in passing. But I definitely should have mentioned it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants