-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LICENSE to include full text of Apache license #1017
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never change somebody else's copyright lines. Especially, not to pretend that the content got created this year. It's not how it works. This could probably go to the notice file, I suppose. But it might be good to have a discussion first.
a4e8f9d
to
ee6dc92
Compare
I mean, this isn't me changing it, this is me proposing a change, you are welcome to reject it but I don't think I'm in the wrong for proposing it and it feels rather weird to get such a response to a PR. I reset the year to 2016, apologies for not mentioning that in the PR body. I've noticed most open source projects like to keep the year up to date and haven't found any that dislike that, so I felt I could just do that in passing. But I definitely should have mentioned it. |
This has nothing to do with liking the year updates but with misunderstanding how copyright works.
IANAL so there might be more nuance to it in some jurisdictions. But the general gist is this. |
The copyright problem has been solved.
LICENSE
Outdated
same "printed page" as the copyright notice for easier | ||
identification within third-party archives. | ||
|
||
Copyright 2016 Andrew Svetlov and aio-libs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should still mention the contributors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I could swear I copy pasted that over correctly, perhaps it got truncated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized that this should actually be moved elsewhere: #1017 (comment)
ee6dc92
to
47ec5c2
Compare
Okay, I see where you're coming from. I disagree that this comes from my misunderstanding of copyright: I know these things, I was just following common practice, and I already apologized for not mentioning that the year had changed in the PR. It is extremely common for codebases that mention a year (which, I agree, isn't best practice!) to update the year. In the past when I've done license fixes like this sometimes folks have asked me to fix the year while I'm at it. It's not incorrect to update the year to a new year, the year is not super load bearing when it comes to this since as you say in point 1, the year is implicitly a property of the code regardless of what the codebase says. |
file or class name and description of purpose be included on the | ||
same "printed page" as the copyright notice for easier | ||
identification within third-party archives. | ||
|
||
Copyright 2016 Andrew Svetlov and aio-libs contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI this is supposed to be boilerplate for the notice. The actual notice would go to a file called NOTICE
.
It's common to have the full license in the repo so that various tooling can correctly recognize it.