🧪 Skip tests when building x86_64 wheels
#946
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing is redundant when building wheels for x86_64 since there are dedicated jobs that run tests for this arch. Disabling it reduces build time noticeably. Related documentation: - https://cibuildwheel.readthedocs.io/en/stable/options/#test-skip
psf-chronographer
bot
added
the
bot:chronographer:provided
|
Hello @webknjaz, |
|
I'm hesitant about this: cibuildwheel tests run under a different environment so I feel like we'd benefit from covering more ground this way. Yes, it'd cut the CI use but I'm not sure that's what we need. Besides, if we were to disable this, it should be on the CI configuration level, not a tool-global — local runs would still benefit from producing wheels that go through the testing stage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @webknjaz,
What do these changes do?
Testing is redundant when building wheels for
x86_64since there are dedicated jobs that run tests for this arch.Disabling it reduces build time noticeably.
Related documentation:
Are there changes in behavior for the user?
CI/CDbuild time will be reduced.Related issue number
N/AChecklist
Best regards!