Improve performance of URL.with_scheme (#1322)

aio-libs · Oct 18, 2024 · 78c1616 · 78c1616
1 parent bcd9936
commit 78c1616
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGES/1322.misc.rst b/CHANGES/1322.misc.rst
@@ -0,0 +1 @@
+Improved performance of the :py:meth:`~yarl.URL.with_scheme` method -- by :user:`bdraco`.
diff --git a/yarl/_url.py b/yarl/_url.py
@@ -1172,13 +1172,15 @@ def with_scheme(self, scheme: str) -> "URL":
         if not isinstance(scheme, str):
             raise TypeError("Invalid scheme type")
         lower_scheme = scheme.lower()
-        if not self._val.netloc and lower_scheme in SCHEME_REQUIRES_HOST:
+        _, netloc, path, query, fragment = self._val
+        if not netloc and lower_scheme in SCHEME_REQUIRES_HOST:
             msg = (
                 "scheme replacement is not allowed for "
                 f"relative URLs for the {lower_scheme} scheme"
             )
             raise ValueError(msg)
-        return self._from_val(self._val._replace(scheme=lower_scheme))
+        val = tuple.__new__(SplitResult, (lower_scheme, netloc, path, query, fragment))
+        return self._from_val(val)
 
     def with_user(self, user: Union[str, None]) -> "URL":
         """Return a new URL with user replaced.