Improve performance of with_query when passing an empty value (#1328)

aio-libs · Oct 18, 2024 · a071e6d · a071e6d
1 parent 8e445f4
commit a071e6d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGES/1328.misc.rst b/CHANGES/1328.misc.rst
@@ -0,0 +1 @@
+1308.misc.rst
diff --git a/yarl/_url.py b/yarl/_url.py
@@ -1342,7 +1342,7 @@ def _query_var(v: QueryVariable) -> str:
 
     @classmethod
     def _get_str_query_from_iterable(
-        cls, items: Iterable[tuple[Union[str, istr], str]]
+        cls, items: Iterable[tuple[Union[str, istr], SimpleQuery]]
     ) -> str:
         """Return a query string from an iterable.
 
@@ -1364,7 +1364,7 @@ def _get_str_query_from_iterable(
     def _get_str_query(cls, *args: Any, **kwargs: Any) -> Union[str, None]:
         query: Union[str, Mapping[str, QueryVariable], None]
         if kwargs:
-            if len(args) > 0:
+            if args:
                 raise ValueError(
                     "Either kwargs or single query parameter must be present"
                 )
@@ -1376,6 +1376,8 @@ def _get_str_query(cls, *args: Any, **kwargs: Any) -> Union[str, None]:
 
         if query is None:
             return None
+        if not query:
+            return ""
         if isinstance(query, Mapping):
             return cls._get_str_query_from_sequence_iterable(query.items())
         if isinstance(query, str):