Accept objects that support __int__ for query vars #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would only accept subclasses of int, we will now accept any object that implements __int__ and has the correct protocol.
bdraco
commented
Sep 9, 2024
…accept_supports_int_float
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1139 +/- ##
=======================================
Coverage 95.41% 95.42%
=======================================
Files 30 30
Lines 4756 4761 +5
Branches 422 423 +1
=======================================
+ Hits 4538 4543 +5
Misses 192 192
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This caused a performance regression, but we didn't know it at the time since we were not monitoring performance Fixed in #1259 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Previously we would only accept subclasses of int, we will now accept any object that implements
__int__and has the correct protocol.Are there changes in behavior for the user?
np.int16will now be acceptedRelated issue number
closes #945