-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize building query strings with MultiDict #1256
Conversation
most of the time aiohttp is passing in a multidict here
This comment was marked as outdated.
This comment was marked as outdated.
CodSpeed Performance ReportMerging #1256 will improve performances by 28.21%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1256 +/- ##
=======================================
Coverage 95.83% 95.84%
=======================================
Files 27 27
Lines 5168 5174 +6
Branches 314 314
=======================================
+ Hits 4953 4959 +6
Misses 189 189
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Most of the time aiohttp is passing in a MulitDict here. This will also help a bit for
dict
without Sequence, but as not a common of a caseFor historical reasons we have support for sequences inside of MulitDict even though it shouldn't happen and it would be a breaking change to remove it